Changeset 52009 in vbox

Timestamp:

Jul 14, 2014 5:27:31 AM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

94972

Message:

Comments and nits.

Location:

trunk/src/VBox

Files:

• Main/src-client/ConsoleImpl2.cpp (modified) (1 diff)
• VMM/VMMR0/HMSVMR0.cpp (modified) (1 diff)
• VMM/VMMR0/HMVMXR0.cpp (modified) (1 diff)
• VMM/VMMR3/GIMMinimal.cpp (modified) (6 diffs)
• VMM/VMMR3/VM.cpp (modified) (1 diff)
• VMM/include/GIMHvInternal.h (modified) (1 diff)
• VMM/include/GIMInternal.h (modified) (1 diff)

trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp

@@ -1218 +1218 @@
             && fOsXGuest)
         {
+            /* When adding new OS X types, please add corresponding types to GIMOSID and
+               update GIMR3IsOSXGuest().  */
             GIMOSID enmOsId = GIMOSID_OSX;
             if (osTypeId == "MacOS_64")

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -5132 +5132 @@
     STAM_COUNTER_INC(&pVCpu->hm.s.StatExitGuestDB);
 
-
     /* This can be a fault-type #DB (instruction breakpoint) or a trap-type #DB (data breakpoint). However, for both cases
        DR6 and DR7 are updated to what the exception handler expects. See AMD spec. 15.12.2 "#DB (Debug)". */

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -6385 +6385 @@
      *
      * The present bit and the unusable bit has been observed to be set at the
-     * same time (the selector was supposed to invalid as we started executing
+     * same time (the selector was supposed to be invalid as we started executing
      * a V8086 interrupt in ring-0).
      *

trunk/src/VBox/VMM/VMMR3/GIMMinimal.cpp

@@ -64 +64 @@
                     uMaxIntelFamilyModelStep = RT_MAKE_U32_FROM_U8(1, 23, 6, 7); /* Penryn / X5482. */
                     break;
+
                 case GIMOSID_OSX_106:
                 case GIMOSID_OSX_106_64:
                     uMaxIntelFamilyModelStep = RT_MAKE_U32_FROM_U8(1, 23, 6, 7); /* Penryn / X5482 */
                     break;
+
                 case GIMOSID_OSX_107:
                 case GIMOSID_OSX_107_64:
@@ -73 +75 @@
                     uMaxIntelFamilyModelStep = RT_MAKE_U32_FROM_U8(1, 23, 6, 7); /* Penryn / X5482 */
                     break;
+
                 case GIMOSID_OSX_108:
                 case GIMOSID_OSX_108_64:
@@ -78 +81 @@
                     uMaxIntelFamilyModelStep = RT_MAKE_U32_FROM_U8(1, 23, 6, 7); /* Penryn / X5482 */
                     break;
+
                 case GIMOSID_OSX_109:
                 case GIMOSID_OSX_109_64:
@@ -91 +95 @@
             {
                 CPUMCPUIDLEAF Leaf;
-                int rc = CPUMR3CpuIdGetLeaf(pVM, &Leaf, 1, 0);
+                int rc = CPUMR3CpuIdGetLeaf(pVM, &Leaf, 1, 0 /* uSubLeaf */);
                 if (RT_SUCCESS(rc))
                 {
@@ -101 +105 @@
                     {
                         uint32_t uNew = Leaf.uEax & UINT32_C(0xf0003000);
-                        uNew |=  RT_BYTE1(uMaxIntelFamilyModelStep) & 0xf;       /* stepping */
-                        uNew |= (RT_BYTE2(uMaxIntelFamilyModelStep) & 0xf) << 4; /* 4 low model bits */
-                        uNew |= (RT_BYTE2(uMaxIntelFamilyModelStep) >> 4) << 16; /* 4 high model bits */
-                        uNew |= (RT_BYTE3(uMaxIntelFamilyModelStep) & 0xf) << 8; /* 4 low family bits */
+                        uNew |=  RT_BYTE1(uMaxIntelFamilyModelStep) & 0xf;          /* stepping */
+                        uNew |= (RT_BYTE2(uMaxIntelFamilyModelStep) & 0xf) << 4;    /* 4 low model bits */
+                        uNew |= (RT_BYTE2(uMaxIntelFamilyModelStep) >> 4) << 16;    /* 4 high model bits */
+                        uNew |= (RT_BYTE3(uMaxIntelFamilyModelStep) & 0xf) << 8;    /* 4 low family bits */
                         /* 8 high family bits, Intel's suggested calculation. */
                         if (RT_BYTE3(uMaxIntelFamilyModelStep) > 0xf)
@@ -133 +137 @@
     }
 
-    /** @todo Register CPUID leaves, MSR ranges with CPUM. */
-    /** -XXX_ CPUMGetGuestCpuId CPUMGetGuestCpuVendor CPUMR3CpuIdInsert  */
     return VINF_SUCCESS;
 }

trunk/src/VBox/VMM/VMMR3/VM.cpp

@@ -986 +986 @@
                                                                 if (RT_SUCCESS(rc))
                                                                 {
-                                                                    /* GIM must be init'd before PDM, DevGIM construction may
-                                                                       require GIM provider to be setup. */
+                                                                    /* GIM must be init'd before PDM, gimdevR3Construct()
+                                                                       requires GIM provider to be setup. */
                                                                     rc = GIMR3Init(pVM);
                                                                     if (RT_SUCCESS(rc))

trunk/src/VBox/VMM/include/GIMHvInternal.h

@@ -21 +21 @@
 #include <VBox/vmm/gim.h>
 #include <VBox/vmm/cpum.h>
+
+/**
+ * GIM Hyper-V saved-state version.
+ */
+#define GIM_HV_SSM_VERSION                 0x1
 
 /** @name Hyper-V base feature identification.

trunk/src/VBox/VMM/include/GIMInternal.h

@@ -44 +44 @@
     /** The provider that is active for this VM. */
     GIMPROVIDERID                    enmProviderId;
-    /** The interface version. */
+    /** The interface implementation version. */
     uint32_t                         u32Version;