Changeset 52381 in vbox

Timestamp:

Aug 14, 2014 1:02:35 PM (10 years ago)

Author:

vboxsync

Message:

FE/Qt: Mac OS X: Runtime UI: Remove unnecessary mini-toolbar shadow.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• runtime/UIStatusBarEditorWindow.cpp (modified) (1 diff)
• widgets/UIMiniToolBar.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIStatusBarEditorWindow.cpp

@@ -736 +736 @@
     setAttribute(Qt::WA_NoSystemBackground);
 # if defined(Q_WS_MAC)
-    /* Using native API to enable translucent background for the Mac host.
-     * - We also want to disable window-shadows which is possible
-     *   using Qt::WA_MacNoShadow only since Qt 4.8,
-     *   while minimum supported version is 4.7.1 for now: */
+    /* Using native API to enable translucent background:
+     * - Under Mac host Qt doesn't allows to disable window-shadows
+     *   until version 4.8, but minimum supported version is 4.7.1. */
     ::darwinSetShowsWindowTransparent(this, true);
 # elif defined(Q_WS_WIN)
     /* Using Qt API to enable translucent background:
-     * - Under Win host Qt conflicts with 3D stuff (black seamless regions).
      * - Under Mac host Qt doesn't allows to disable window-shadows
-     *   until version 4.8, but minimum supported version is 4.7.1 for now.
-     * - Under x11 host Qt has it broken with KDE 4.9 (black background): */
+     *   until version 4.8, but minimum supported version is 4.7.1.
+     * - Under x11 host Qt has broken XComposite support (black background): */
     setAttribute(Qt::WA_TranslucentBackground);
 # endif /* Q_WS_WIN */

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIMiniToolBar.cpp

@@ -36 +36 @@
 #include "UIIconPool.h"
 #include "VBoxGlobal.h"
+#ifdef Q_WS_MAC
+# include "VBoxUtils-darwin.h"
+#endif /* Q_WS_MAC */
 
 #ifndef Q_WS_X11
@@ -198 +201 @@
 {
 #ifdef VBOX_RUNTIME_UI_WITH_SHAPED_MINI_TOOLBAR
-    /* Using Qt API to enable translucent background: */
-    setAttribute(Qt::WA_TranslucentBackground, true);
+    /* Make sure we have no background
+     * until the first one paint-event: */
+    setAttribute(Qt::WA_NoSystemBackground);
+# if defined(Q_WS_MAC)
+    /* Using native API to enable translucent background:
+     * - Under Mac host Qt doesn't allows to disable window-shadows
+     *   until version 4.8, but minimum supported version is 4.7.1. */
+    ::darwinSetShowsWindowTransparent(this, true);
+# elif defined(Q_WS_WIN)
+    /* Using Qt API to enable translucent background:
+     * - Under Mac host Qt doesn't allows to disable window-shadows
+     *   until version 4.8, but minimum supported version is 4.7.1.
+     * - Under x11 host Qt has broken XComposite support (black background): */
+    setAttribute(Qt::WA_TranslucentBackground);
+# endif /* Q_WS_WIN */
 #endif /* VBOX_RUNTIME_UI_WITH_SHAPED_MINI_TOOLBAR */