Changeset 52411 in vbox for trunk/src/VBox/VMM/VMMRZ

Timestamp:

Aug 19, 2014 11:00:46 AM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

95582

Message:

VMM/HMVMXR0: Use unordered atomics for VMMRZCallRing3[Enable|Disable]() and some VT-x nits.

File:

• trunk/src/VBox/VMM/VMMRZ/VMMRZ.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMRZ/VMMRZ.cpp

@@ -134 +134 @@
 
     Assert(pVCpu->vmm.s.cCallRing3Disabled < 16);
-    if (ASMAtomicIncU32(&pVCpu->vmm.s.cCallRing3Disabled) == 1) /** @todo replace with unordered variant (ASMAtomicUoIncU32). */
-    {                                                           /** @todo See @bugref{6208} comment #36 for impl. diff. */
+    if (ASMAtomicUoIncU32(&pVCpu->vmm.s.cCallRing3Disabled) == 1)
+    {
         /** @todo it might make more sense to just disable logging here, then we
          * won't flush away important bits... but that goes both ways really. */
@@ -155 +155 @@
 
 /**
- * Counters VMMRZCallRing3Disable and re-enables host calls.
+ * Counters VMMRZCallRing3Disable() and re-enables host calls.
  *
  * @param   pVCpu               The CPU struct for the calling EMT.
@@ -168 +168 @@
 
     Assert(pVCpu->vmm.s.cCallRing3Disabled > 0);
-    if (ASMAtomicDecU32(&pVCpu->vmm.s.cCallRing3Disabled) == 0) /** @todo replace with unordered variant (ASMAtomicUoDecU32). */
+    if (ASMAtomicUoDecU32(&pVCpu->vmm.s.cCallRing3Disabled) == 0)
     {
 #ifdef IN_RC