Changeset 52482 in vbox for trunk/src

Timestamp:

Aug 22, 2014 8:38:31 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

95703

Message:

SUP: TrustedInstaller or LocalSystem, works around tumbleweed desktop validator issue.

File:

• trunk/src/VBox/HostDrivers/Support/win/SUPHardenedVerifyImage-win.cpp (modified) (11 diffs)

trunk/src/VBox/HostDrivers/Support/win/SUPHardenedVerifyImage-win.cpp

@@ -137 +137 @@
 #endif /* IN_RING3 */
 
-/** The TrustedInstaller SID (Vista+). */
 static union
 {
     SID                     Sid;
     uint8_t                 abPadding[SECURITY_MAX_SID_SIZE];
-}                           g_TrustedInstallerSid;
+}
+/** The TrustedInstaller SID (Vista+). */
+                            g_TrustedInstallerSid,
+/** Local system ID (S-1-5-21). */
+                            g_LocalSystemSid;
+
 
 /** Set after we've retrived other SPC root certificates from the system. */
@@ -411 +415 @@
 
 /**
- * Checks if the file is owned by TrustedInstaller on Vista and later.
+ * Checks if the file is owned by TrustedInstaller (Vista+) or similar.
  *
  * @returns true if owned by TrustedInstaller of pre-Vista, false if not.
@@ -418 +422 @@
  * @param   pwszName            The name of the file.
  */
-static bool supHardNtViCheckIsOwnedByTrustedInstaller(HANDLE hFile, PCRTUTF16 pwszName)
+static bool supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(HANDLE hFile, PCRTUTF16 pwszName)
 {
     if (g_uNtVerCombined < SUP_NT_VER_VISTA)
@@ -442 +446 @@
     /*
      * Check the owner.
+     *
+     * Initially we wished to only allow TrustedInstaller.  But a Winodws CAPI
+     * plugin "Program Files\Tumbleweed\Desktop Validator\tmwdcapiclient.dll"
+     * turned up owned by the local system user, and we cannot operate without
+     * the plugin loaded once it's installed (WinVerityTrust fails).
      */
     PSID pOwner = uBuf.Rel.Control & SE_SELF_RELATIVE ? &uBuf.abView[uBuf.Rel.Owner] : uBuf.Abs.Owner;
     Assert((uintptr_t)pOwner - (uintptr_t)&uBuf < sizeof(uBuf) - sizeof(SID));
     if (RtlEqualSid(pOwner, &g_TrustedInstallerSid))
+        return true;
+    if (RtlEqualSid(pOwner, &g_LocalSystemSid))
         return true;
 
@@ -705 +716 @@
         /* Must be owned by trusted installer. (This test is superfuous, thus no relaxation here.) */
         if (   !(fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-            && !supHardNtViCheckIsOwnedByTrustedInstaller(hFile, pwszName))
+            && !supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(hFile, pwszName))
             return rc;
 
@@ -762 +773 @@
         /* Must be owned by trusted installer. */
         if (   !(fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-            && !supHardNtViCheckIsOwnedByTrustedInstaller(hFile, pwszName))
+            && !supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(hFile, pwszName))
             return rc;
         return VINF_LDRVI_NOT_SIGNED;
@@ -779 +790 @@
 
         if (   !(fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-            && !supHardNtViCheckIsOwnedByTrustedInstaller(hFile, pwszName))
+            && !supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(hFile, pwszName))
             return rc;
 
@@ -827 +838 @@
     {
         if (   !(fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-            && !supHardNtViCheckIsOwnedByTrustedInstaller(hFile, pwszName))
+            && !supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(hFile, pwszName))
             return rc;
         return VINF_LDRVI_NOT_SIGNED;
@@ -837 +848 @@
      */
     if (   (fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-        || supHardNtViCheckIsOwnedByTrustedInstaller(hFile, pwszName))
+        || supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(hFile, pwszName))
         return VINF_LDRVI_NOT_SIGNED;
 
@@ -1015 +1026 @@
      * user32.dll.  Since we need user32.dll and will be checking it's digital
      * signature, it's reasonably safe to let this thru.
+     * (The report was of SECURITY_BUILTIN_DOMAIN_RID + DOMAIN_ALIAS_RID_ADMINS
+     * owning user32.dll, see public ticket 13187, VBoxStartup.3.log.)
      */
     if (   (pNtViRdr->fFlags & SUPHNTVI_F_TRUSTED_INSTALLER_OWNER)
-        && !supHardNtViCheckIsOwnedByTrustedInstaller(pNtViRdr->hFile, pwszName))
+        && !supHardNtViCheckIsOwnedByTrustedInstallerOrSimilar(pNtViRdr->hFile, pwszName))
     {
         if (!supHardViUtf16PathStartsWithEx(pwszName, (uint32_t)RTUtf16Len(pwszName),
@@ -1615 +1628 @@
                 *RtlSubAuthoritySid(&g_TrustedInstallerSid, 4) = 1853292631;
                 *RtlSubAuthoritySid(&g_TrustedInstallerSid, 5) = 2271478464;
-                return VINF_SUCCESS;
+
+                if (NT_SUCCESS(rcNt))
+                    rcNt = RtlInitializeSid(&g_LocalSystemSid, &s_NtAuth, 1);
+                if (NT_SUCCESS(rcNt))
+                {
+                    *RtlSubAuthoritySid(&g_LocalSystemSid, 0) = SECURITY_LOCAL_SYSTEM_RID;
+                    return VINF_SUCCESS;
+                }
             }
             rc = RTErrConvertFromNtStatus(rcNt);