Changeset 52597 in vbox for trunk/src

Timestamp:

Sep 4, 2014 5:07:37 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

95872

Message:

Devices/Misc/VirtualKD: new, slightly modified interface definition which avoids the need to know the rpc command header size

File:

• trunk/src/VBox/Devices/Misc/VirtualKD.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Misc/VirtualKD.cpp

@@ -34 +34 @@
 *******************************************************************************/
 
-#define IKDClient_InterfaceVersion 2
+#define IKDClient_InterfaceVersion 3
 
 
@@ -60 +60 @@
 {
 public:
-    virtual unsigned OnRequest(const char *pRequest, unsigned RequestSize, char **ppReply)=0;
-    virtual unsigned GetRPCCommandHeaderSize()=0;
+    virtual unsigned OnRequest(const char *pRequestIncludingRpcHeader, unsigned RequestSizeWithRpcHeader, char **ppReply)=0;
     virtual ~IKDClient() {}
 };
@@ -73 +72 @@
     RTLDRMOD hLib;
     IKDClient *pKDClient;
-    unsigned cbRPCCommandHeaderSize;
     char abCmdBody[262144];
 } VIRTUALKD;
@@ -104 +102 @@
     if (Port == 0x5659)
     {
-        VKDREQUESTHDR RequestHeader;
+        VKDREQUESTHDR RequestHeader = {0, };
         int rc = PDMDevHlpPhysRead(pDevIns, (RTGCPHYS)u32, &RequestHeader, sizeof(RequestHeader));
         if (!RT_SUCCESS(rc) || !RequestHeader.cbData)
@@ -114 +112 @@
         char *pReply = NULL;
         unsigned cbReply;
-        cbReply = pThis->pKDClient->OnRequest(pThis->abCmdBody + pThis->cbRPCCommandHeaderSize,
-                                              RequestHeader.cbData - pThis->cbRPCCommandHeaderSize,
+        cbReply = pThis->pKDClient->OnRequest(pThis->abCmdBody,
+                                              RequestHeader.cbData,
                                               &pReply);
 
@@ -158 +156 @@
     pThis->hLib = NIL_RTLDRMOD;
     pThis->pKDClient = NULL;
-    pThis->cbRPCCommandHeaderSize = 0;
 
     if (!CFGMR3AreValuesValid(pCfg,
@@ -205 +202 @@
         return VINF_SUCCESS;
     }
-
-    pThis->cbRPCCommandHeaderSize = pThis->pKDClient->GetRPCCommandHeaderSize();
 
     PDMDevHlpIOPortRegister(pDevIns, 0x5658, 2, NULL, vkdPortWrite, vkdPortRead, NULL, NULL, "VirtualKD");