Changeset 52611 in vbox

Timestamp:

Sep 5, 2014 9:44:51 AM (10 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Added ApicAccessToR3 stat and addressed a 4.3 todo.

Location:

trunk/src/VBox/VMM

Files:

• VMMR0/HMVMXR0.cpp (modified) (1 diff)
• VMMR3/HM.cpp (modified) (6 diffs)
• include/HMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -11220 +11220 @@
 
     STAM_COUNTER_INC(&pVCpu->hm.s.StatExitApicAccess);
+    if (rc != VINF_SUCCESS)
+        STAM_COUNTER_INC(&pVCpu->hm.s.StatExitApicAccessToR3);
     return rc;
 }

trunk/src/VBox/VMM/VMMR3/HM.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2006-2013 Oracle Corporation
+ * Copyright (C) 2006-2014 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -703 +703 @@
         HM_REG_COUNTER(&pVCpu->hm.s.StatExitMtf,                "/HM/CPU%d/Exit/MonitorTrapFlag", "Monitor Trap Flag.");
         HM_REG_COUNTER(&pVCpu->hm.s.StatExitApicAccess,         "/HM/CPU%d/Exit/ApicAccess", "APIC access. Guest attempted to access memory at a physical address on the APIC-access page.");
+        HM_REG_COUNTER(&pVCpu->hm.s.StatExitApicAccessToR3,     "/HM/CPU%d/Exit/ApicAccessToR3", "APIC access causing us to go to ring-3.");
 
         HM_REG_COUNTER(&pVCpu->hm.s.StatSwitchGuestIrq,         "/HM/CPU%d/Switch/IrqPending", "PDMGetInterrupt() cleared behind our back!?!.");
@@ -1232 +1233 @@
         else
         {
-            /** @todo This cannot possibly work, there are other places which assumes
-             *        this allocation cannot fail (see HMR3CanExecuteGuest()). Make this
-             *        a failure case. */
             LogRel(("HM: No real mode VT-x support (PDMR3VMMDevHeapAlloc returned %Rrc)\n", rc));
             pVM->hm.s.vmx.pRealModeTSS = NULL;
             pVM->hm.s.vmx.pNonPagingModeEPTPageTable = NULL;
+            return VMSetError(pVM, rc, RT_SRC_POS,
+                              "HM failure: No real mode VT-x support (PDMR3VMMDevHeapAlloc returned %Rrc)", rc);
         }
     }
@@ -2466 +2466 @@
         /*
          * The VMM device heap is a requirement for emulating real mode or protected mode without paging with the unrestricted
-         * guest execution feature i missing (VT-x only).
+         * guest execution feature is missing (VT-x only).
          */
         if (fSupportsRealMode)
@@ -2666 +2666 @@
 
 /**
- * Checks if we are currently using hardware accelerated raw mode.
+ * Checks if we are currently using hardware acceleration.
  *
  * @returns true if hardware acceleration is being used, otherwise false.
@@ -2678 +2678 @@
 
 /**
- * External interface for querying whether hardware accelerated raw mode is
- * enabled.
+ * External interface for querying whether hardware acceleration is enabled.
  *
  * @returns true if VT-x or AMD-V is being used, otherwise false.

trunk/src/VBox/VMM/include/HMInternal.h

@@ -912 +912 @@
     STAMCOUNTER             StatExitMtf;
     STAMCOUNTER             StatExitApicAccess;
+    STAMCOUNTER             StatExitApicAccessToR3;
     STAMCOUNTER             StatPendingHostIrq;