Changeset 52623 in vbox for trunk/src/VBox/HostServices/SharedOpenGL

Timestamp:

Sep 5, 2014 7:14:21 PM (10 years ago)

Author:

vboxsync

Message:

Mac OS X host: 3D: offline rendering check: fix atomic variables mess.

File:

• trunk/src/VBox/HostServices/SharedOpenGL/OpenGLTest/OpenGLTestDarwin.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/OpenGLTest/OpenGLTestDarwin.cpp

@@ -51 +51 @@
        on startup. */
 
-    static bool volatile fState = false;
-    if (!ASMAtomicCmpXchgBool(&fState, true, false))
+#define VBOX_OGL_CHECK_UNINITIALIZED    (0)
+#define VBOX_OGL_CHECK_INITIALIZING     (1)
+#define VBOX_OGL_CHECK_INITIALIZED      (2)
+
+    /* Transition VBOX_OGL_CHECK_UNINITIALIZED -> VBOX_OGL_CHECK_INITIALIZING means the current thread
+       is the first one who entered the routine. In this case, it should detect number of GPUs, cache result
+       and return it. If it's not TRUE, then fInitialized is VBOX_OGL_CHECK_INITIALIZING (another thread is performing
+       the check; current thread should wait till result will be cached and return it) or VBOX_OGL_CHECK_INITIALIZED
+       (result is already cached; just return it.) */
+
+    static uint8_t volatile fInitialized = VBOX_OGL_CHECK_UNINITIALIZED;
+    if (!ASMAtomicCmpXchgU8(&fInitialized, VBOX_OGL_CHECK_INITIALIZING, VBOX_OGL_CHECK_UNINITIALIZED))
     {
-        while (ASMAtomicReadBool(&fState) != true)
+        while (ASMAtomicReadU8(&fInitialized) != VBOX_OGL_CHECK_INITIALIZED)
             RTThreadSleep(5);
 
@@ -94 +104 @@
 
     LogRel(("OpenGL: Offline rendering support is %s (PID=%d)\n", fAppropriate ? "ON" : "OFF", (int)getpid()));
+
+    ASMAtomicWriteU8(&fInitialized, VBOX_OGL_CHECK_INITIALIZED);
 
     return fAppropriate;