Changeset 52884 in vbox for trunk/src/VBox/VMM

Timestamp:

Sep 29, 2014 10:17:11 AM (10 years ago)

Author:

vboxsync

Message:

IEM: Added comments where code does not match comments and/or Intel manuals.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -1186 +1186 @@
         {
             Log(("jmpf %04x:%08RX64 -> out of bounds (%#x)\n", uSel, offSeg, cbLimit));
+            /** @todo: Intel says this is #GP(0)! */
             return iemRaiseGeneralProtectionFaultBySelector(pIemCpu, uSel);
         }
@@ -1381 +1382 @@
         {
             Log(("callf %04x:%08RX64 -> out of bounds (%#x)\n", uSel, offSeg, cbLimit));
+            /** @todo: Intel says this is #GP(0)! */
             return iemRaiseGeneralProtectionFaultBySelector(pIemCpu, uSel);
         }
@@ -1693 +1695 @@
                 Log(("retf %04x:%08RX64 %04x:%08RX64 - out of bounds (%#x)-> #GP(CS).\n",
                      uNewCs, uNewRip, uNewOuterSs, uNewOuterRsp, cbLimitCs));
+                /** @todo: Intel says this is #GP(0)! */
                 return iemRaiseGeneralProtectionFaultBySelector(pIemCpu, uNewCs);
             }
@@ -1785 +1788 @@
             {
                 Log(("retf %04x:%08RX64 -> out of bounds (%#x)\n", uNewCs, uNewRip, cbLimitCs));
+                /** @todo: Intel says this is #GP(0)! */
                 return iemRaiseGeneralProtectionFaultBySelector(pIemCpu, uNewCs);
             }
@@ -2572 +2576 @@
             Log(("iret %04x:%08x/%04x:%08x -> EIP is out of bounds (%#x) -> #GP(0)\n",
                  uNewCs, uNewEip, uNewSS, uNewESP, cbLimitCS));
+            /** @todo: Which is it, #GP(0) or #GP(sel)? */
             return iemRaiseSelectorBoundsBySelector(pIemCpu, uNewCs);
         }
@@ -2648 +2653 @@
         {
             Log(("iret %04x:%08x - EIP is out of bounds (%#x) -> #GP(0)\n", uNewCs, uNewEip, cbLimitCS));
+            /** @todo: Which is it, #GP(0) or #GP(sel)? */
             return iemRaiseSelectorBoundsBySelector(pIemCpu, uNewCs);
         }
@@ -2901 +2907 @@
             Log(("iret %04x:%016RX64/%04x:%016RX64 -> EIP is out of bounds (%#x) -> #GP(0)\n",
                  uNewCs, uNewRip, uNewSs, uNewRsp, cbLimitCS));
+            /** @todo: Which is it, #GP(0) or #GP(sel)? */
             return iemRaiseSelectorBoundsBySelector(pIemCpu, uNewCs);
         }