Changeset 53034 in vbox for trunk

Timestamp:

Oct 10, 2014 11:39:15 PM (10 years ago)

Author:

vboxsync

Message:

SUP: Missing two FILE_SYNCHRONOUS_IO_NONALERT flags, one of which seems responsible for the occational BSOD 4E (9a,...).

Location:

trunk/src/VBox/HostDrivers/Support/win

Files:

• SUPHardenedVerifyImage-win.cpp (modified) (1 diff)
• SUPHardenedVerifyProcess-win.cpp (modified) (1 diff)
• SUPR3HardenedMain-win.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/win/SUPHardenedVerifyImage-win.cpp

@@ -254 +254 @@
         }
 
+/** @todo This nonsense is probably due to missing FILE_SYNCHRONOUS_IO_NONALERT
+ *        flags in early code stage.  Should clean this up, but leave code
+ *        for handling STATUS_PENDING as we don't know what callers of
+ *        NtCreateSection might've been passing to their NtCreateFile calls.
+ *        In ring-0, this code is mostly pointless, I think. */
         /*
          * Delay a little before we retry?

trunk/src/VBox/HostDrivers/Support/win/SUPHardenedVerifyProcess-win.cpp

@@ -1818 +1818 @@
                                  FILE_SHARE_READ,
                                  FILE_OPEN,
-                                 FILE_NON_DIRECTORY_FILE, /** @todo nonalert? */
+                                 FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT,
                                  NULL /*EaBuffer*/,
                                  0 /*EaLength*/);

trunk/src/VBox/HostDrivers/Support/win/SUPR3HardenedMain-win.cpp

@@ -4848 +4848 @@
                                  FILE_SHARE_READ,
                                  FILE_OPEN,
-                                 FILE_NON_DIRECTORY_FILE,
+                                 FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT,
                                  NULL /*EaBuffer*/,
                                  0 /*EaLength*/);
@@ -5306 +5306 @@
         InitializeObjectAttributes(&ObjAttr, &UniStrName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
         rcNt = NtCreateFile(&hFile, GENERIC_READ, &ObjAttr, &Ios, NULL /* Allocation Size*/,  FILE_ATTRIBUTE_NORMAL,
-                            FILE_SHARE_READ, FILE_OPEN, FILE_NON_DIRECTORY_FILE, NULL /*EaBuffer*/, 0 /*EaLength*/);
+                            FILE_SHARE_READ, FILE_OPEN, FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT,
+                            NULL /*EaBuffer*/, 0 /*EaLength*/);
         if (NT_SUCCESS(rcNt) && NT_SUCCESS(Ios.Status))
         {