Changeset 53036 in vbox for trunk

Timestamp:

Oct 11, 2014 7:48:10 AM (10 years ago)

Author:

vboxsync

Message:

SUP: NtCreateFile requires SYNCHRONIZE access when FILE_SYNCHRONOUS_IO_NONALERT is used, while in user mode anyways.

Location:

trunk/src/VBox/HostDrivers/Support/win

Files:

• SUPHardenedVerifyProcess-win.cpp (modified) (1 diff)
• SUPLib-win.cpp (modified) (2 diffs)
• SUPR3HardenedMain-win.cpp (modified) (6 diffs)

trunk/src/VBox/HostDrivers/Support/win/SUPHardenedVerifyProcess-win.cpp

@@ -1811 +1811 @@
 
     NTSTATUS rcNt = NtCreateFile(&hFile,
-                                 GENERIC_READ,
+                                 GENERIC_READ | SYNCHRONIZE,
                                  &ObjAttr,
                                  &Ios,

trunk/src/VBox/HostDrivers/Support/win/SUPLib-win.cpp

@@ -158 +158 @@
 
         NTSTATUS rcNt = NtCreateFile(&hDevice,
-                                     GENERIC_READ | GENERIC_WRITE,
+                                     GENERIC_READ | GENERIC_WRITE, /* No SYNCHRONIZE. */
                                      &ObjAttr,
                                      &Ios,
@@ -165 +165 @@
                                      FILE_SHARE_READ | FILE_SHARE_WRITE,
                                      FILE_OPEN,
-                                     FILE_NON_DIRECTORY_FILE,
+                                     FILE_NON_DIRECTORY_FILE, /* No FILE_SYNCHRONOUS_IO_NONALERT! */
                                      NULL /*EaBuffer*/,
                                      0 /*EaLength*/);

trunk/src/VBox/HostDrivers/Support/win/SUPR3HardenedMain-win.cpp

@@ -4221 +4221 @@
     InitializeObjectAttributes(&ObjAttr, &NtName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
     NTSTATUS rcNt = NtCreateFile(&hFile,
-                                 GENERIC_READ,
+                                 GENERIC_READ, /* No SYNCHRONIZE. */
                                  &ObjAttr,
                                  &Ios,
@@ -4228 +4228 @@
                                  FILE_SHARE_READ | FILE_SHARE_WRITE,
                                  FILE_OPEN,
-                                 FILE_NON_DIRECTORY_FILE,
+                                 FILE_NON_DIRECTORY_FILE, /* No FILE_SYNCHRONOUS_IO_NONALERT. */
                                  NULL /*EaBuffer*/,
                                  0 /*EaLength*/);
@@ -4374 +4374 @@
 
         rcNt = NtCreateFile(&hFile,
-                            GENERIC_READ | GENERIC_WRITE,
+                            GENERIC_READ | GENERIC_WRITE, /* No SYNCHRONIZE. */
                             &ObjAttr,
                             &Ios,
@@ -4381 +4381 @@
                             FILE_SHARE_READ | FILE_SHARE_WRITE,
                             FILE_OPEN,
-                            FILE_NON_DIRECTORY_FILE,
+                            FILE_NON_DIRECTORY_FILE, /* No FILE_SYNCHRONOUS_IO_NONALERT. */
                             NULL /*EaBuffer*/,
                             0 /*EaLength*/);
@@ -4841 +4841 @@
     InitializeObjectAttributes(&ObjAttr, &UniStrName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
     NTSTATUS rcNt = NtCreateFile(&hFile,
-                                 GENERIC_READ,
+                                 GENERIC_READ | SYNCHRONIZE,
                                  &ObjAttr,
                                  &Ios,
@@ -5305 +5305 @@
         UniStrName.MaximumLength = UniStrName.Length + sizeof(WCHAR);
         InitializeObjectAttributes(&ObjAttr, &UniStrName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
-        rcNt = NtCreateFile(&hFile, GENERIC_READ, &ObjAttr, &Ios, NULL /* Allocation Size*/,  FILE_ATTRIBUTE_NORMAL,
-                            FILE_SHARE_READ, FILE_OPEN, FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT,
-                            NULL /*EaBuffer*/, 0 /*EaLength*/);
+        rcNt = NtCreateFile(&hFile, GENERIC_READ | SYNCHRONIZE, &ObjAttr, &Ios, NULL /* Allocation Size*/,
+                            FILE_ATTRIBUTE_NORMAL, FILE_SHARE_READ, FILE_OPEN,
+                            FILE_NON_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT, NULL /*EaBuffer*/, 0 /*EaLength*/);
         if (NT_SUCCESS(rcNt) && NT_SUCCESS(Ios.Status))
         {