Changeset 53081 in vbox

Timestamp:

Oct 16, 2014 6:43:26 PM (10 years ago)

Author:

vboxsync

Message:

Runtime/r3: do not use a hard-coded stack size in rtSchedRunThread(), and PTHREAD_CREATE_JOINABLE is the default anyway.

File:

• trunk/src/VBox/Runtime/r3/linux/sched-linux.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/linux/sched-linux.cpp

@@ -312 +312 @@
 {
     /*
-     * Setup thread attributes.
-     */
-    pthread_attr_t  ThreadAttr;
-    int rc = pthread_attr_init(&ThreadAttr);
+     * Create the thread.
+     */
+    pthread_t Thread;
+    int rc = pthread_create(&Thread, NULL, pfnThread, pvArg);
     if (!rc)
     {
-        rc = pthread_attr_setdetachstate(&ThreadAttr, PTHREAD_CREATE_JOINABLE);
-        if (!rc)
+        /*
+         * Wait for the thread to finish.
+         */
+        void *pvRet = (void *)-1;
+        do
         {
-            rc = pthread_attr_setstacksize(&ThreadAttr, 128*1024);
-            if (!rc)
-            {
-                /*
-                 * Create the thread.
-                 */
-                pthread_t Thread;
-                rc = pthread_create(&Thread, &ThreadAttr, pfnThread, pvArg);
-                if (!rc)
-                {
-                    /*
-                     * Wait for the thread to finish.
-                     */
-                    void *pvRet = (void *)-1;
-                    do
-                    {
-                        rc = pthread_join(Thread, &pvRet);
-                    } while (errno == EINTR);
-                    if (rc)
-                        return RTErrConvertFromErrno(rc);
-                    return (int)(uintptr_t)pvRet;
-                }
-            }
-        }
-        pthread_attr_destroy(&ThreadAttr);
+            rc = pthread_join(Thread, &pvRet);
+        } while (errno == EINTR);
+        if (rc)
+            return RTErrConvertFromErrno(rc);
+        return (int)(uintptr_t)pvRet;
     }
     return RTErrConvertFromErrno(rc);