Changeset 53147 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Oct 26, 2014 5:40:21 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

96682

Message:

Storage/AHCI: Free the I/O memory of cached request structures before unmounting the CD/DVD medium. Fixes a crash when a medium was removed from a drive without inserting a new one before the AHCI controller is destroyed

File:

• trunk/src/VBox/Devices/Storage/DevAHCI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -943 +943 @@
                                 void *pvBuf, size_t cbBuf);
 static bool ahciCancelActiveTasks(PAHCIPort pAhciPort, PAHCIREQ pAhciReqExcept);
+static void ahciReqMemFree(PAHCIPort pAhciPort, PAHCIREQ pAhciReq, bool fForceFree);
 #endif
 RT_C_DECLS_END
@@ -4635 +4636 @@
                     PAHCI pAhci = pAhciPort->CTX_SUFF(pAhci);
                     PPDMDEVINS pDevIns = pAhci->CTX_SUFF(pDevIns);
+
+                    /*
+                     * Free the I/O memory of all cached tasks of this port
+                     * because the driver providing I/O memory allocation interface
+                     * is about to be destroyed.
+                     */
+                    for (uint32_t i = 0; i < AHCI_NR_COMMAND_SLOTS; i++)
+                    {
+                        if (pAhciPort->aCachedTasks[i])
+                            ahciReqMemFree(pAhciPort, pAhciPort->aCachedTasks[i], true /* fForceFree */);
+                    }
 
                     rc = VMR3ReqPriorityCallWait(PDMDevHlpGetVM(pDevIns), VMCPUID_ANY,