Changeset 53196 in vbox

Timestamp:

Nov 4, 2014 12:52:21 PM (10 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Fix incorrect sign and calculation on guest TSC offset in VMCS.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -5620 +5620 @@
         fOffsettedTsc = TMCpuTickCanUseRealTSC(pVCpu, &pVCpu->hm.s.vmx.u64TSCOffset, &fParavirtTsc);
 
-#if 1
     if (fParavirtTsc)
     {
-#if 1
+        /** @todo this is a hack until TM switches to pure-offsetting mode. */
         uint64_t const u64CurTsc   = ASMReadTSC();
         uint64_t const u64LastTick = TMCpuTickGetLastSeen(pVCpu);
-        if (u64CurTsc + pVCpu->hm.s.vmx.u64TSCOffset < u64LastTick)
-        {
-            pVCpu->hm.s.vmx.u64TSCOffset = (u64LastTick - u64CurTsc);
+        if (u64CurTsc - pVCpu->hm.s.vmx.u64TSCOffset < u64LastTick)
+        {
+            pVCpu->hm.s.vmx.u64TSCOffset = u64CurTsc - u64LastTick;
             STAM_COUNTER_INC(&pVCpu->hm.s.StatTscOffsetAdjusted);
         }
 
-        Assert(u64CurTsc + pVCpu->hm.s.vmx.u64TSCOffset >= u64LastTick);
-#endif
+        Assert(u64CurTsc - pVCpu->hm.s.vmx.u64TSCOffset >= u64LastTick);
         rc = GIMR0UpdateParavirtTsc(pVM, pVCpu->hm.s.vmx.u64TSCOffset);
         AssertRC(rc);
@@ -5643 +5641 @@
         STAM_COUNTER_INC(&pVCpu->hm.s.StatTscParavirt);
     }
-    else
-#else
-    if (fParavirtTsc)
-        STAM_COUNTER_INC(&pVCpu->hm.s.StatTscParavirt);
-#endif
-    if (fOffsettedTsc)
+    else if (fOffsettedTsc)
     {
         uint64_t u64CurTSC = ASMReadTSC();
-        if (u64CurTSC + pVCpu->hm.s.vmx.u64TSCOffset >= TMCpuTickGetLastSeen(pVCpu))
+        if (u64CurTSC - pVCpu->hm.s.vmx.u64TSCOffset >= TMCpuTickGetLastSeen(pVCpu))
         {
             /* Note: VMX_VMCS_CTRL_PROC_EXEC_RDTSC_EXIT takes precedence over TSC_OFFSET, applies to RDTSCP too. */
-            rc = VMXWriteVmcs64(VMX_VMCS64_CTRL_TSC_OFFSET_FULL, pVCpu->hm.s.vmx.u64TSCOffset);   AssertRC(rc);
+            rc = VMXWriteVmcs64(VMX_VMCS64_CTRL_TSC_OFFSET_FULL, -pVCpu->hm.s.vmx.u64TSCOffset);  AssertRC(rc);
 
             pVCpu->hm.s.vmx.u32ProcCtls &= ~VMX_VMCS_CTRL_PROC_EXEC_RDTSC_EXIT;
@@ -8731 +8724 @@
     {
         /** @todo Find a way to fix hardcoding a guestimate.  */
-        TMCpuTickSetLastSeen(pVCpu, ASMReadTSC()
-                             + pVCpu->hm.s.vmx.u64TSCOffset - 0x400   /* guestimate of world switch overhead in clock ticks */);
+        TMCpuTickSetLastSeen(pVCpu, ASMReadTSC() - pVCpu->hm.s.vmx.u64TSCOffset
+                             - 0x400  /* guestimate of world switch overhead in clock ticks */);
     }