Changeset 53303 in vbox for trunk/src/VBox/Devices/Network/slirp

Timestamp:

Nov 11, 2014 2:19:29 PM (10 years ago)

Author:

vboxsync

Message:

NAT: set icmp type (to echo reply) using mbuf api when we reply to
pings directed to slirp itself.

This fixes replies to fragmented requests for which we used to update
a contiguous copy instead of the original mbuf and so we ended up
replying back with echo requests.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -412 +412 @@
                 || CTL_CHECK(dst, CTL_TFTP))
             {
-                icp->icmp_type = ICMP_ECHOREPLY;
+                uint8_t echo_reply = ICMP_ECHOREPLY;
+                m_copyback(pData, m, hlen + RT_OFFSETOF(struct icmp, icmp_type),
+                           sizeof(echo_reply), (caddr_t)&echo_reply);
                 ip->ip_dst.s_addr = ip->ip_src.s_addr;
                 ip->ip_src.s_addr = dst;