Changeset 53369 in vbox for trunk/src/VBox

Timestamp:

Nov 21, 2014 12:08:21 PM (10 years ago)

Author:

vboxsync

Message:

HostDrivers/Support: minimize interrupt disabled time while measuring TSC deltas, thanks to Windows watchdog.

File:

• trunk/src/VBox/HostDrivers/Support/SUPDrv.c (modified) (5 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrv.c

@@ -6612 +6612 @@
                 idxNewGipMaster = supdrvGipCpuIndexFromCpuId(pGip, idNewGipMaster);
                 iTSCDelta       = pGip->aCPUs[idxNewGipMaster].i64TSCDelta;
-                Assert(iTSCDelta != UINT64_MAX);
+                Assert(iTSCDelta != INT64_MAX);
                 for (i = 0; i < pGip->cCpus; i++)
                 {
@@ -6750 +6750 @@
     while (cTriesLeft-- > 0)
     {
-        unsigned    i;
-        uint64_t    uMinCmpReadTime = UINT64_MAX;
+        unsigned i;
+        uint64_t uMinCmpReadTime = UINT64_MAX;
         for (i = 0; i < GIP_TSC_DELTA_LOOPS; i++)
         {
-            RTCCUINTREG uFlags = ASMIntDisableFlags();   /* Disable interrupts per-iteration, see @bugref{6710} comment #38. */
             if (idCpu == idMaster)
             {
@@ -6760 +6759 @@
                  * The master.
                  */
+                RTCCUINTREG uFlags;
                 Assert(pGipCpuMaster->u64TSCSample == GIP_TSC_DELTA_RSVD);
                 ASMAtomicWriteU32(&g_pTscDeltaSync->u, GIP_TSC_DELTA_SYNC_START);
+
+                /* Disable interrupts only in the master for as short a period
+                   as possible, thanks again to Windows. See @bugref{6710} comment #73. */
+                uFlags = ASMIntDisableFlags();
+
                 while (ASMAtomicReadU32(&g_pTscDeltaSync->u) == GIP_TSC_DELTA_SYNC_START)
                     ;
@@ -6770 +6775 @@
                     ASMAtomicWriteU64(&pGipCpuMaster->u64TSCSample, ASMReadTSC());
                 } while (pGipCpuMaster->u64TSCSample == GIP_TSC_DELTA_RSVD);
+
+                ASMSetFlags(uFlags);
 
                 while (ASMAtomicReadU32(&g_pTscDeltaSync->u) != GIP_TSC_DELTA_SYNC_WORKER_DONE)
@@ -6839 +6846 @@
                     ASMNopPause();
             }
-
-            ASMSetFlags(uFlags);
         }