Changeset 53513 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

Dec 11, 2014 4:21:20 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

97253

Message:

Devices/Graphics: safety checks when setting IRQs.

File:

• trunk/src/VBox/Devices/Graphics/HGSMI/HGSMIHost.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Graphics/HGSMI/HGSMIHost.cpp

@@ -495 +495 @@
     VM_ASSERT_EMT(pIns->pVM);
 
+    AssertPtrReturn(pIns->pHGFlags, VERR_WRONG_ORDER);
     int rc = hgsmiFIFOLock(pIns);
     AssertRC(rc);
@@ -546 +547 @@
 void HGSMISetHostGuestFlags(HGSMIINSTANCE *pIns, uint32_t flags)
 {
+    AssertPtrReturnVoid(pIns->pHGFlags);
     ASMAtomicOrU32(&pIns->pHGFlags->u32HostFlags, flags);
 }
@@ -551 +553 @@
 void HGSMIClearHostGuestFlags(HGSMIINSTANCE *pIns, uint32_t flags)
 {
+    AssertPtrReturnVoid(pIns->pHGFlags);
     ASMAtomicAndU32(&pIns->pHGFlags->u32HostFlags, (~flags));
 }
@@ -852 +855 @@
     HGSMIHOSTFIFOENTRY *pEntry;
 
+    AssertPtrReturn(pIns->pHGFlags, VERR_WRONG_ORDER);
     int rc = hgsmiHostFIFOAlloc (pIns, &pEntry);
 
@@ -1891 +1895 @@
     HGSMIGUESTCOMPLENTRY *pEntry = NULL;
 
+    AssertPtrReturn(pIns->pHGFlags, VERR_WRONG_ORDER);
     int rc = hgsmiGuestCompletionFIFOAlloc (pIns, &pEntry);
     AssertRC(rc);