Changeset 53596 in vbox

Timestamp:

Dec 21, 2014 11:53:18 PM (10 years ago)

Author:

vboxsync

Message:

SVGA/SVGA3d: Moved hexdumps from LogFlow() to Log2(), Log3(), and Log4().

Location:

trunk/src/VBox/Devices/Graphics

Files:

• DevVGA-SVGA.cpp (modified) (2 diffs)
• DevVGA-SVGA3d-ogl.cpp (modified) (4 diffs)
• DevVGA-SVGA3d-win.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp

@@ +1 @@
+/* $Id$ */
 /** @file
- * VMWare SVGA device
+ * VMWare SVGA device.
+ *
+ * Logging levels guidelines for this and related files:
+ *  - Log() for normal bits.
+ *  - LogFlow() for more info.
+ *  - Log2 for hex dump of cursor data.
+ *  - Log3 for hex dump of shader code.
+ *  - Log4 for hex dumps of 3D data.
  */
+
 /*
- * Copyright (C) 2013 Oracle Corporation
+ * Copyright (C) 2013-2014 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -2128 +2137 @@
                 AssertBreak(pCursorCopy);
 
-                LogFlow(("Cursor data:\n%.*Rhxd\n", pCursor->width * pCursor->height * sizeof(uint32_t), pCursor+1));
+                Log2(("Cursor data:\n%.*Rhxd\n", pCursor->width * pCursor->height * sizeof(uint32_t), pCursor+1));
 
                 /* Transparency is defined by the alpha bytes, so make the whole bitmap visible. */

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp

@@ -2182 +2182 @@
                                     pBoxes[i].d * pBoxes[i].h);
 
-            LogFlow(("first line:\n%.*Rhxd\n", pMipLevel->cbSurface, pMipLevel->pSurfaceData));
+            Log4(("first line:\n%.*Rhxd\n", pMipLevel->cbSurface, pMipLevel->pSurfaceData));
 
             AssertRC(rc);
@@ -2344 +2344 @@
                 }
 
-                LogFlow(("first line:\n%.*Rhxd\n", pBoxes[i].w * pSurface->cbBlock, pDoubleBuffer));
+                Log4(("first line:\n%.*Rhxd\n", pBoxes[i].w * pSurface->cbBlock, pDoubleBuffer));
 
                 /* Free the double buffer. */
@@ -2386 +2386 @@
                 AssertRC(rc);
 
-                LogFlow(("first line:\n%.*Rhxd\n", cbSrcPitch, pData));
+                Log4(("first line:\n%.*Rhxd\n", cbSrcPitch, pData));
 
                 pState->ext.glUnmapBuffer(GL_ARRAY_BUFFER);
@@ -5883 +5883 @@
 
     Log(("vmsvga3dShaderDefine cid=%x shid=%x type=%s cbData=%x\n", cid, shid, (type == SVGA3D_SHADERTYPE_VS) ? "VERTEX" : "PIXEL", cbData));
-    LogFlow(("shader code:\n%.*Rhxd\n", cbData, pShaderData));
+    Log3(("shader code:\n%.*Rhxd\n", cbData, pShaderData));
 
     if (    cid >= pState->cContexts

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win.cpp

@@ -2370 +2370 @@
                                     pBoxes[i].d * pBoxes[i].h);
 
-            LogFlow(("first line:\n%.*Rhxd\n", pMipLevel->cbSurfacePitch, pMipLevel->pSurfaceData));
+            Log4(("first line:\n%.*Rhxd\n", pMipLevel->cbSurfacePitch, pMipLevel->pSurfaceData));
 
             AssertRC(rc);
@@ -2507 +2507 @@
                 AssertRC(rc);
 
-                LogFlow(("first line:\n%.*Rhxd\n", pBoxes[i].w * pSurface->cbBlock, LockedRect.pBits));
+                Log4(("first line:\n%.*Rhxd\n", pBoxes[i].w * pSurface->cbBlock, LockedRect.pBits));
 
                 if (fTexture)
@@ -2579 +2579 @@
                 AssertRC(rc);
 
-                LogFlow(("first line:\n%.*Rhxd\n", cbSrcPitch, pData));
+                Log4(("first line:\n%.*Rhxd\n", cbSrcPitch, pData));
 
                 if (fVertex)
@@ -5695 +5695 @@
 
     Log(("vmsvga3dShaderDefine %x shid=%x type=%s cbData=%x\n", cid, shid, (type == SVGA3D_SHADERTYPE_VS) ? "VERTEX" : "PIXEL", cbData));
-    LogFlow(("shader code:\n%.*Rhxd\n", cbData, pShaderData));
+    Log3(("shader code:\n%.*Rhxd\n", cbData, pShaderData));
 
     if (    cid >= pState->cContexts