Changeset 53891 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd/client

Timestamp:

Jan 21, 2015 10:51:49 AM (10 years ago)

Author:

vboxsync

Message:

XPCOM: Fix message leak when a client death notification is received while there is another message on the queue

File:

• trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp (modified) (2 diffs)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp

@@ -1144 +1144 @@
     return rv;
 
-  // if the requested sender has died while waiting, return an error
-  if (data.senderDead)
-    return NS_ERROR_ABORT; // XXX better error code?
-
   // if the selector has accepted some message, then we pass it to aConsumer
   // for safe processing.  The IPC susbsystem is quite stable here (i.e. we're
@@ -1161 +1157 @@
 
   delete msg;
+
+  // if the requested sender has died while waiting, return an error
+  if (data.senderDead)
+    return NS_ERROR_ABORT; // XXX better error code?
 
   return NS_OK;