Changeset 5393 in vbox for trunk/src

Timestamp:

Oct 19, 2007 5:28:17 PM (17 years ago)

Author:

vboxsync

Message:

When flushing a page because it's been reused, don't emulate instructions that fail interpretation. This gets rid of the majority of the failures due to SSE2 instructions on solaris.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -707 +707 @@
      * Check if it's worth dealing with.
      */
+    bool fReused = false;
     if (    (   pPage->cModifications < 48   /** @todo #define */ /** @todo need to check that it's not mapping EIP. */ /** @todo adjust this! */
              || pPage->fCR3Mix)
-        &&  !pgmPoolMonitorIsReused(pPage, &Cpu, pvFault)
+        &&  !(fReused = pgmPoolMonitorIsReused(pPage, &Cpu, pvFault))
         &&  !pgmPoolMonitorIsForking(pPool, &Cpu, GCPhysFault & PAGE_OFFSET_MASK))
     {
@@ -752 +753 @@
     /*
      * Not worth it, so flush it.
+     *
+     * If we considered it to be reused, don't to back to ring-3 
+     * to emulate failed instructions since we usually cannot 
+     * interpret then. This may be a bit risky, in which case
+     * the reuse detection must be fixed.
      */
     rc = pgmPoolAccessHandlerFlush(pVM, pPool, pPage, &Cpu, pRegFrame, GCPhysFault, pvFault);
+    if (rc == VINF_EM_RAW_EMULATE_INSTR && fReused)
+        rc = VINF_SUCCESS;
     STAM_PROFILE_STOP_EX(&pVM->pgm.s.CTXSUFF(pPool)->CTXSUFF(StatMonitor), &pPool->CTXMID(StatMonitor,FlushPage), a);
     return rc;