Changeset 54104 in vbox for trunk/src/VBox/Frontends

Timestamp:

Feb 6, 2015 6:49:01 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

98075

Message:

FE/Qt: Runtime UI: UIFrameBuffer refactoring for 6278 and 3635 (step 2): Separate performRescale interface to handle scaling stuff.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• UIFrameBuffer.cpp (modified) (3 diffs)
• UIFrameBuffer.h (modified) (2 diffs)
• UIMachineView.cpp (modified) (10 diffs)
• UIMachineView.h (modified) (1 diff)
• scale/UIMachineViewScale.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp

@@ -88 +88 @@
         prepareConnections();
 
-    /* Resize frame-buffer to default size: */
+    /* Resize/rescale frame-buffer to the default size: */
     performResize(640, 480);
+    performRescale();
 
 #ifdef Q_OS_WIN
@@ -761 +762 @@
 
     unlock();
-
-    /* Update scaled-size according scale-factor for modes except the 'Scale' one: */
-    if (m_pMachineView->machineLogic()->visualStateType() != UIVisualStateType_Scale)
-        setScaledSize(scaleFactor() == 1.0 ? QSize() : QSize((int)(m_iWidth * scaleFactor()), (int)(m_iHeight * scaleFactor())));
+}
+
+void UIFrameBuffer::performRescale()
+{
+//    printf("UIFrameBuffer::performRescale\n");
+
+    /* Make sure machine-view is assigned: */
+    AssertPtrReturnVoid(m_pMachineView);
+
+    /* Depending on current visual state: */
+    switch (m_pMachineView->machineLogic()->visualStateType())
+    {
+        case UIVisualStateType_Scale:
+            m_scaledSize = m_scaledSize.width() == m_iWidth && m_scaledSize.height() == m_iHeight ? QSize() : m_scaledSize;
+            break;
+        default:
+            m_scaledSize = scaleFactor() == 1.0 ? QSize() : QSize((int)(m_iWidth * scaleFactor()), (int)(m_iHeight * scaleFactor()));
+            break;
+    }
+
+    /* Update coordinate-system: */
+    updateCoordinateSystem();
+
+//    printf("UIFrameBuffer::performRescale: Complete: Scale-factor=%f, Scaled-size=%dx%d\n",
+//           scaleFactor(), scaledSize().width(), scaledSize().height());
 }
 
@@ -776 +798 @@
 }
 #endif /* VBOX_WITH_VIDEOHWACCEL */
-
-void UIFrameBuffer::setScaleFactor(double dScaleFactor)
-{
-    /* Remember new scale-factor: */
-    m_dScaleFactor = dScaleFactor;
-
-    /* Update scaled-size according scale-factor: */
-    setScaledSize(scaleFactor() == 1.0 ? QSize() : QSize((int)(m_iWidth * scaleFactor()), (int)(m_iHeight * scaleFactor())));
-
-    /* Update coordinate-system: */
-    updateCoordinateSystem();
-}
-
-void UIFrameBuffer::setBackingScaleFactor(double dBackingScaleFactor)
-{
-    /* Remember new backing-scale-factor: */
-    m_dBackingScaleFactor = dBackingScaleFactor;
-
-    /* Update coordinate-system: */
-    updateCoordinateSystem();
-}
-
-void UIFrameBuffer::setUseUnscaledHiDPIOutput(bool fUseUnscaledHiDPIOutput)
-{
-    /* Remember new use-unscaled-HiDPI-output value: */
-    m_fUseUnscaledHiDPIOutput = fUseUnscaledHiDPIOutput;
-
-    /* Update coordinate-system: */
-    updateCoordinateSystem();
-}
 
 void UIFrameBuffer::prepareConnections()

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.h

@@ -208 +208 @@
     /** Performs frame-buffer resizing. */
     virtual void performResize(int iWidth, int iHeight);
+    /** Performs frame-buffer rescaling. */
+    virtual void performRescale();
 
 #ifdef VBOX_WITH_VIDEOHWACCEL
@@ -221 +223 @@
     double scaleFactor() const { return m_dScaleFactor; }
     /** Define the scale-factor used by the frame-buffer. */
-    void setScaleFactor(double dScaleFactor);
+    void setScaleFactor(double dScaleFactor) { m_dScaleFactor = dScaleFactor; }
 
     /** Returns backing-scale-factor used by HiDPI frame-buffer. */
     double backingScaleFactor() const { return m_dBackingScaleFactor; }
     /** Defines backing-scale-factor used by HiDPI frame-buffer. */
-    void setBackingScaleFactor(double dBackingScaleFactor);
+    void setBackingScaleFactor(double dBackingScaleFactor) { m_dBackingScaleFactor = dBackingScaleFactor; }
 
     /** Returns whether frame-buffer should use unscaled HiDPI output. */
     bool useUnscaledHiDPIOutput() const { return m_fUseUnscaledHiDPIOutput; }
     /** Defines whether frame-buffer should use unscaled HiDPI output. */
-    void setUseUnscaledHiDPIOutput(bool fUseUnscaledHiDPIOutput);
+    void setUseUnscaledHiDPIOutput(bool fUseUnscaledHiDPIOutput) { m_fUseUnscaledHiDPIOutput = fUseUnscaledHiDPIOutput; }
 
     /** Return HiDPI frame-buffer optimization type. */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.cpp

@@ -183 +183 @@
     const bool fUseUnscaledHiDPIOutput = gEDataManager->useUnscaledHiDPIOutput(vboxGlobal().managedVMUuid());
     frameBuffer()->setUseUnscaledHiDPIOutput(fUseUnscaledHiDPIOutput);
+
+    /* Perform frame-buffer rescaling: */
+    frameBuffer()->performRescale();
 }
 
@@ -234 +237 @@
                                    frameBuffer()->height() != (ulong)iHeight;
 
-        /* Adjust 'scale' mode to current machine-view size: */
+        /* Perform frame-buffer mode-change: */
+        frameBuffer()->handleNotifyChange(iWidth, iHeight);
+
+        /* For 'scale' mode: */
         if (visualStateType() == UIVisualStateType_Scale)
         {
@@ -240 +246 @@
             frameBuffer()->setScaledSize(size());
         }
-
-        /* Perform frame-buffer mode-change: */
-        frameBuffer()->handleNotifyChange(iWidth, iHeight);
-
-        /* Scale-mode doesn't need this.. */
-        if (visualStateType() != UIVisualStateType_Scale)
+        /* For other than 'scale' mode: */
+        else
         {
             /* Adjust maximum-size restriction for machine-view: */
@@ -267 +269 @@
                 machineWindow()->normalizeGeometry(true /* adjust position */);
         }
+
+        /* Perform frame-buffer rescaling: */
+        frameBuffer()->performRescale();
 
 #ifdef Q_WS_MAC
@@ -362 +367 @@
                                       (uint32_t)(dScaleFactor * VBOX_OGL_SCALE_FACTOR_MULTIPLIER));
 
-    /* Adjust frame-buffer, machine-window and guest-screen size if necessary: */
-    sltHandleNotifyChange(frameBuffer()->width(), frameBuffer()->height());
-    frameBuffer()->performResize(frameBuffer()->width(), frameBuffer()->height());
-    machineWindow()->normalizeGeometry(true /* adjust position */);
+    /* Handle scale attributes change: */
+    handleScaleChange();
+    /* Adjust guest-screen size: */
     adjustGuestScreenSize();
 
@@ -383 +387 @@
     frameBuffer()->setUseUnscaledHiDPIOutput(fUseUnscaledHiDPIOutput);
 
-    /* Adjust frame-buffer, machine-window and guest-screen size if necessary: */
-    sltHandleNotifyChange(frameBuffer()->width(), frameBuffer()->height());
-    frameBuffer()->performResize(frameBuffer()->width(), frameBuffer()->height());
-    machineWindow()->normalizeGeometry(true /* adjust position */);
+    /* Handle scale attributes change: */
+    handleScaleChange();
+    /* Adjust guest-screen size: */
     adjustGuestScreenSize();
 
@@ -558 +561 @@
         m_pFrameBuffer->setUseUnscaledHiDPIOutput(fUseUnscaledHiDPIOutput);
 
+        /* Perform frame-buffer rescaling: */
+        m_pFrameBuffer->performRescale();
+
         /* Associate uisession with frame-buffer finally: */
         uisession()->setFrameBuffer(screenId(), m_pFrameBuffer);
@@ -598 +604 @@
         }
 
-        /* If we have a valid size, resize the framebuffer. */
+        /* If we have a valid size, resize/rescale the frame-buffer. */
         if (size.width() > 0 && size.height() > 0)
+        {
             frameBuffer()->performResize(size.width(), size.height());
+            frameBuffer()->performRescale();
+        }
     }
 }
@@ -844 +853 @@
     /* Return size: */
     return size;
+}
+
+void UIMachineView::handleScaleChange()
+{
+    LogRel(("UIMachineView::handleScaleChange: Screen=%d.\n",
+            (unsigned long)m_uScreenId));
+
+    /* If machine-window is visible: */
+    if (uisession()->isScreenVisible(m_uScreenId))
+    {
+        /* For 'scale' mode: */
+        if (visualStateType() == UIVisualStateType_Scale)
+        {
+            /* Assign new frame-buffer logical-size: */
+            frameBuffer()->setScaledSize(size());
+        }
+        /* For other than 'scale' mode: */
+        else
+        {
+            /* Adjust maximum-size restriction for machine-view: */
+            setMaximumSize(sizeHint());
+
+            /* Disable the resize hint override hack: */
+            m_sizeHintOverride = QSize(-1, -1);
+
+            /* Force machine-window update own layout: */
+            QCoreApplication::sendPostedEvents(0, QEvent::LayoutRequest);
+
+            /* Update machine-view sliders: */
+            updateSliders();
+
+            /* By some reason Win host forgets to update machine-window central-widget
+             * after main-layout was updated, let's do it for all the hosts: */
+            machineWindow()->centralWidget()->update();
+
+            /* Normalize 'normal' machine-window geometry: */
+            if (visualStateType() == UIVisualStateType_Normal)
+                machineWindow()->normalizeGeometry(true /* adjust position */);
+        }
+
+        /* Perform frame-buffer rescaling: */
+        frameBuffer()->performRescale();
+    }
+
+    LogRelFlow(("UIMachineView::handleScaleChange: Complete for Screen=%d.\n",
+                (unsigned long)m_uScreenId));
 }
 
@@ -1233 +1288 @@
             case QEvent::Move:
             {
-                /* Update backing-scale-factor for underlying frame-buffer: */
                 if (m_pFrameBuffer)
+                {
+                    /* Update backing-scale-factor for underlying frame-buffer: */
                     m_pFrameBuffer->setBackingScaleFactor(darwinBackingScaleFactor(machineWindow()));
+                    /* Perform frame-buffer rescaling: */
+                    m_pFrameBuffer->performRescale();
+                }
                 break;
             }

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.h

@@ -196 +196 @@
     QSize guestSizeHint();
 
+    /** Handles machine-view scale changes. */
+    void handleScaleChange();
+
     /* Protected setters: */
     /** Store a guest size hint value to extra data, called on switching to

trunk/src/VBox/Frontends/VirtualBox/src/runtime/scale/UIMachineViewScale.cpp

@@ -66 +66 @@
     saveMachineViewSettings();
 
-    /* Return scaled-size to 'default' mode: */
-    UIMachineView::applyMachineViewScaleFactor();
-
     /* Cleanup frame buffer: */
     cleanupFrameBuffer();
@@ -76 +73 @@
 {
     /* Adjust frame-buffer scaled-size: */
-    frameBuffer()->setScaledSize(viewport()->size());
+    frameBuffer()->setScaledSize(size());
+    frameBuffer()->performRescale();
 
     /* If scaled-size is valid: */
@@ -150 +148 @@
     const bool fUseUnscaledHiDPIOutput = gEDataManager->useUnscaledHiDPIOutput(vboxGlobal().managedVMUuid());
     frameBuffer()->setUseUnscaledHiDPIOutput(fUseUnscaledHiDPIOutput);
+
+    /* Perform frame-buffer rescaling: */
+    frameBuffer()->performRescale();
 }