Changeset 54116 in vbox

Timestamp:

Feb 9, 2015 3:29:23 PM (10 years ago)

Author:

vboxsync

Message:

NAT: icmpwin_ping - don't decrement TTL once again, this is done in
ip_input(), where time exceeded is also handled.

Note, that this is not correct, since time exceeded should not be
generated for packets with TTL 1 that are for "us", i.e. one of the
CTL_ALIAS addresses. But for now just do as the Romans do.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmpwin.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/ip_icmpwin.c

@@ -141 +141 @@
 
     ttl = ip->ip_ttl;
-    AssertReturnVoid(ttl > 1); /* should've been dealt with in the caller */
-    --ttl;
+    AssertReturnVoid(ttl > 0);
 
     reqsize = ip->ip_len - hlen - sizeof(struct icmp_echo);