Changeset 54174 in vbox for trunk/src/VBox/Main

Timestamp:

Feb 12, 2015 12:48:47 PM (10 years ago)

Author:

vboxsync

Message:

Main/Machine: fix lock order violation when detaching all media, child lock must not be held when taking parent lock (should fix public ticket #13789). Contributed by Alexander Urakov. Thanks!

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -11091 +11091 @@
                 llMedia.push_back(pMedium);
                 ComObjPtr<Medium> pParent = pMedium->i_getParent();
+                /* Not allowed to keep this lock as below we need the parent
+                 * medium lock, and the lock order is parent to child. */
+                lock.release();
                 /*
                  * Search for medias which are not attached to any machine, but