Changeset 54175 in vbox for trunk/src/VBox/Main

Timestamp:

Feb 12, 2015 12:52:54 PM (10 years ago)

Author:

vboxsync

Message:

Main/Machine: fix another (unnecessary, the parent lock isn't needed at all) lock order violation. Fixes public bug ticket #13801. Contributed by Alexander Urakov. Thanks!

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -11191 +11191 @@
                )
             {
-                ComObjPtr<Medium> parent = pMedium->i_getParent();
-                AutoWriteLock parentLock(parent COMMA_LOCKVAL_SRC_POS);
-
                 /* update the appropriate lock list */
                 MediumLockList *pMediumLockList;
@@ -11207 +11204 @@
                         fMediaNeedsLocking = true;
                     }
-                    rc = pMediumLockList->Update(parent, false);
+                    rc = pMediumLockList->Update(pMedium->getParent(), false);
                     AssertComRC(rc);
                     rc = pMediumLockList->Append(pMedium, true);