Changeset 54176 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd

Timestamp:

Feb 12, 2015 12:59:44 PM (10 years ago)

Author:

vboxsync

Message:

XPCOM/ipcDConnectService.cpp: make sure that sufficient workers are created when several messages arrive before any of them gets picked up by the possibly waiting (or newly created) workers. Not the ideal solution (could create too many workers), but hard to do better with this bad code. Fixes public bug ticket #13802. Contributed by Alexander Urakov. Thanks!

Location:

trunk/src/libs/xpcom18a4/ipc/ipcd

Files:

• extensions/dconnect/src/ipcDConnectService.cpp (modified) (2 diffs)
• shared/src/ipcList.h (modified) (1 diff)

trunk/src/libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp

@@ -3554 +3554 @@
   mon.Enter();
   // examine the queue
-  if (!mPendingQ.IsEmpty() && !mWaitingWorkers)
+  if (mPendingQ.Count() > mWaitingWorkers)
   {
     // wait a little while to let the workers empty the queue.
@@ -3565 +3565 @@
     mon.Enter();
     // examine the queue again
-    if (!mPendingQ.IsEmpty() && !mWaitingWorkers)
+    if (mPendingQ.Count() > mWaitingWorkers)
     {
       // we need one more worker

trunk/src/libs/xpcom18a4/ipc/ipcd/shared/src/ipcList.h

@@ -175 +175 @@
     }
 
+    // gets count of list elements
+    PRUint32 Count()
+    {
+        T *obj = mHead;
+        PRUint32 count = 0;
+        while (obj) {
+            count++;
+            obj = obj->mNext;
+        }
+
+        return count;
+    }
+
 protected:
     void AdvanceHead()