Changeset 54290 in vbox

Timestamp:

Feb 19, 2015 11:16:49 AM (10 years ago)

Author:

vboxsync

Message:

HostDrivers/Support: TSC-delta thread adjustments for tsc-delta measurement ioctl.

Location:

trunk

Files:

• include/VBox/err.h (modified) (1 diff)
• src/VBox/HostDrivers/Support/SUPDrv.c (modified) (16 diffs)
• src/VBox/HostDrivers/Support/SUPDrvInternal.h (modified) (4 diffs)

trunk/include/VBox/err.h

@@ -1782 +1782 @@
  *  TSC-delta. */
 #define VWRN_SUPDRV_TSC_DELTA_MEASUREMENT_FAILED     3746
-
+/** A TSC-delta measurement request is currently being serviced. */
+#define VERR_SUPDRV_TSC_DELTA_MEASUREMENT_BUSY      (-3747)
 /** @} */
 

trunk/src/VBox/HostDrivers/Support/SUPDrv.c

@@ -6012 +6012 @@
         RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
 
-    pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_Butchered;
+    pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_Butchered;
     RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
     OSDBGPRINT(("supdrvTscDeltaThreadButchered: %s. rc=%Rrc\n", rcFailed));
@@ -6037 +6037 @@
          * Switch on the current state.
          */
-        SUPDRVTSCDELTASTATE enmState;
+        SUPDRVTSCDELTATHREADSTATE enmState;
         RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
-        enmState = pDevExt->enmTscDeltaState;
+        enmState = pDevExt->enmTscDeltaThreadState;
         switch (enmState)
         {
-            case kSupDrvTscDeltaState_Creating:
-            {
-                pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_Listening;
+            case kTscDeltaThreadState_Creating:
+            {
+                pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_Listening;
                 rc = RTSemEventSignal(pDevExt->hTscDeltaEvent);
                 if (RT_FAILURE(rc))
@@ -6051 +6051 @@
             }
 
-            case kSupDrvTscDeltaState_Listening:
+            case kTscDeltaThreadState_Listening:
             {
                 RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
@@ -6073 +6073 @@
             }
 
-            case kSupDrvTscDeltaState_WaitAndMeasure:
-            {
-                pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_Measuring;
+            case kTscDeltaThreadState_WaitAndMeasure:
+            {
+                pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_Measuring;
                 rc = RTSemEventSignal(pDevExt->hTscDeltaEvent);
                 if (RT_FAILURE(rc))
@@ -6085 +6085 @@
             }
 
-            case kSupDrvTscDeltaState_Measuring:
+            case kTscDeltaThreadState_Measuring:
             {
                 cConsecutiveTimeouts = 0;
@@ -6117 +6117 @@
                 }
                 RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
-                if (pDevExt->enmTscDeltaState == kSupDrvTscDeltaState_Measuring)
-                    pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_Listening;
+                if (pDevExt->enmTscDeltaThreadState == kTscDeltaThreadState_Measuring)
+                    pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_Listening;
                 RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
                 Assert(rc != VERR_NOT_AVAILABLE);   /* VERR_NOT_AVAILABLE is used as the initial value. */
@@ -6125 +6125 @@
             }
 
-            case kSupDrvTscDeltaState_Terminating:
+            case kTscDeltaThreadState_Terminating:
                 RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
                 return VINF_SUCCESS;
 
-            case kSupDrvTscDeltaState_Butchered:
+            case kTscDeltaThreadState_Butchered:
             default:
                 return supdrvTscDeltaThreadButchered(pDevExt, true /* fSpinlockHeld */, "Invalid state", VERR_INVALID_STATE);
@@ -6149 +6149 @@
  * @param   enmNewState     The new state we're waiting for it to enter.
  */
-static int supdrvTscDeltaThreadWait(PSUPDRVDEVEXT pDevExt, SUPDRVTSCDELTASTATE enmCurState, SUPDRVTSCDELTASTATE enmNewState)
+static int supdrvTscDeltaThreadWait(PSUPDRVDEVEXT pDevExt, SUPDRVTSCDELTATHREADSTATE enmCurState,
+                                    SUPDRVTSCDELTATHREADSTATE enmNewState)
 {
     /*
@@ -6157 +6158 @@
     RTSemEventWait(pDevExt->hTscDeltaEvent, RT_MS_1SEC);
     RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
-    if (pDevExt->enmTscDeltaState == enmNewState)
+    if (pDevExt->enmTscDeltaThreadState == enmNewState)
     {
         RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
         rc = VINF_SUCCESS;
     }
-    else if (pDevExt->enmTscDeltaState == enmCurState)
+    else if (pDevExt->enmTscDeltaThreadState == enmCurState)
     {
         /*
@@ -6175 +6176 @@
              * Check the state whether we've succeeded.
              */
-            SUPDRVTSCDELTASTATE enmState;
+            SUPDRVTSCDELTATHREADSTATE enmState;
             RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
-            enmState = pDevExt->enmTscDeltaState;
+            enmState = pDevExt->enmTscDeltaThreadState;
             RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
             if (enmState == enmNewState)
@@ -6217 +6218 @@
     int rc;
     RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
-    pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_Terminating;
+    pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_Terminating;
     RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
     RTThreadUserSignal(pDevExt->hTscDeltaThread);
@@ -6259 +6260 @@
         if (RT_SUCCESS(rc))
         {
-            pDevExt->enmTscDeltaState   = kSupDrvTscDeltaState_Creating;
+            pDevExt->enmTscDeltaThreadState   = kTscDeltaThreadState_Creating;
             pDevExt->cMsTscDeltaTimeout = 1;
             RTCpuSetEmpty(&pDevExt->TscDeltaCpuSet);
@@ -6267 +6268 @@
             if (RT_SUCCESS(rc))
             {
-                rc = supdrvTscDeltaThreadWait(pDevExt, kSupDrvTscDeltaState_Creating, kSupDrvTscDeltaState_Listening);
+                rc = supdrvTscDeltaThreadWait(pDevExt, kTscDeltaThreadState_Creating, kTscDeltaThreadState_Listening);
                 if (RT_SUCCESS(rc))
                 {
@@ -7102 +7103 @@
         RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
         RTCpuSetAdd(&pDevExt->TscDeltaCpuSet, idCpu);
-        if (   pDevExt->enmTscDeltaState == kSupDrvTscDeltaState_Listening
-            || pDevExt->enmTscDeltaState == kSupDrvTscDeltaState_Measuring)
-        {
-            pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_WaitAndMeasure;
+        if (   pDevExt->enmTscDeltaThreadState == kTscDeltaThreadState_Listening
+            || pDevExt->enmTscDeltaThreadState == kTscDeltaThreadState_Measuring)
+        {
+            pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_WaitAndMeasure;
         }
         RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
@@ -8348 +8349 @@
                 RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
                 RTCpuSetAdd(&pDevExt->TscDeltaCpuSet, pGipCpuWorker->idCpu);
-                if (   pDevExt->enmTscDeltaState == kSupDrvTscDeltaState_Listening
-                    || pDevExt->enmTscDeltaState == kSupDrvTscDeltaState_Measuring)
+                if (   pDevExt->enmTscDeltaThreadState == kTscDeltaThreadState_Listening
+                    || pDevExt->enmTscDeltaThreadState == kTscDeltaThreadState_Measuring)
                 {
-                    pDevExt->enmTscDeltaState = kSupDrvTscDeltaState_WaitAndMeasure;
+                    pDevExt->enmTscDeltaThreadState = kTscDeltaThreadState_WaitAndMeasure;
                 }
                 RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
@@ -8357 +8358 @@
                 return VINF_SUCCESS;
             }
+
+            /*
+             * If a TSC-delta measurement request is already being serviced by the thread,
+             * wait 'cTries' times if a retry-timeout is provided, otherwise bail as busy.
+             */
+            while (cTries-- > 0)
+            {
+                SUPDRVTSCDELTATHREADSTATE enmState;
+                RTSpinlockAcquire(pDevExt->hTscDeltaSpinlock);
+                enmState = pDevExt->enmTscDeltaThreadState;
+                RTSpinlockRelease(pDevExt->hTscDeltaSpinlock);
+
+                if (   enmState == kTscDeltaThreadState_Measuring
+                    || enmState == kTscDeltaThreadState_WaitAndMeasure)
+                {
+                    if (   !cTries
+                        || !cMsWaitRetry)
+                        return VERR_SUPDRV_TSC_DELTA_MEASUREMENT_BUSY;
+                    if (cMsWaitRetry)
+                        RTThreadSleep(cMsWaitRetry);
+                }
+            }
+            cTries = RT_MAX(pReq->u.In.cRetries + 1, 10);
 #endif
 

trunk/src/VBox/HostDrivers/Support/SUPDrvInternal.h

@@ -231 +231 @@
 #endif
 
-#if 0
+#if 1
 /**  Use a dedicated kernel thread to service TSC-delta measurement requests.
  *   @todo Test on servers with many CPUs and sockets. */
@@ -247 +247 @@
  * TSC-delta measurement thread state machine.
  */
-typedef enum SUPDRVTSCDELTASTATE
+typedef enum SUPDRVTSCDELTATHREADSTATE
 {
     /** Uninitialized/invalid value. */
-    kSupDrvTscDeltaState_Invalid = 0,
+    kTscDeltaThreadState_Invalid = 0,
     /** The thread is being created. */
-    kSupDrvTscDeltaState_Creating,
+    kTscDeltaThreadState_Creating,
     /** The thread is listening for events. */
-    kSupDrvTscDeltaState_Listening,
+    kTscDeltaThreadState_Listening,
     /** The thread is sleeping before starting a measurement. */
-    kSupDrvTscDeltaState_WaitAndMeasure,
+    kTscDeltaThreadState_WaitAndMeasure,
     /** The thread is currently servicing a measurement request. */
-    kSupDrvTscDeltaState_Measuring,
+    kTscDeltaThreadState_Measuring,
     /** The thread is terminating. */
-    kSupDrvTscDeltaState_Terminating,
+    kTscDeltaThreadState_Terminating,
     /** The thread is butchered due to an unexpected error. */
-    kSupDrvTscDeltaState_Butchered,
+    kTscDeltaThreadState_Butchered,
     /** The thread is destroyed. */
-    kSupDrvTscDeltaState_Destroyed,
+    kTscDeltaThreadState_Destroyed,
     /** The usual 32-bit blowup hack. */
-    kSupDrvTscDeltaState_32BitHack = 0x7fffffff
-} SUPDRVTSCDELTASTATE;
+    kTscDeltaThreadState_32BitHack = 0x7fffffff
+} SUPDRVTSCDELTATHREADSTATE, *PSUPDRVTSCDELTATHREADSTATE;
 #endif
 
@@ -717 +717 @@
     /** @name TSC-delta measurement thread.
      *  @{ */
-    /** Spinlock protecting enmTscDeltaState. */
+    /** Spinlock protecting enmTscDeltaThreadState. */
     RTSPINLOCK                      hTscDeltaSpinlock;
     /** TSC-delta measurement thread. */
@@ -724 +724 @@
     RTSEMEVENT                      hTscDeltaEvent;
     /** The state of the TSC-delta measurement thread. */
-    SUPDRVTSCDELTASTATE             enmTscDeltaState;
+    SUPDRVTSCDELTATHREADSTATE       enmTscDeltaThreadState;
     /** Thread timeout time before rechecking state in ms. */
     RTMSINTERVAL                    cMsTscDeltaTimeout;