Changeset 54294 in vbox

Timestamp:

Feb 19, 2015 2:17:53 PM (10 years ago)

Author:

vboxsync

Message:

mp: update doc and todo for Solaris, better/lighter API possible it looks like for rescheduling the thread.

Location:

trunk

Files:

• include/iprt/mp.h (modified) (1 diff)
• src/VBox/Runtime/r0drv/solaris/mpnotification-r0drv-solaris.c (modified) (1 diff)

trunk/include/iprt/mp.h

@@ -351 +351 @@
  * Probably not being called on the onlined/offlined CPU...
  *
- * On Solaris we're holding the cpu_lock, IPL/SPL/PIL is not yet known.  Looks
- * like we're being called on the CPU that's being onlined/offlined.
+ * On Solaris we're holding the cpu_lock, IPL/SPL/PIL is not yet known, however
+ * we will most likely -not- be firing on the CPU going offline/online.
  *
  * On Linux it looks like we're called on the CPU in question.  Interrupts may

trunk/src/VBox/Runtime/r0drv/solaris/mpnotification-r0drv-solaris.c

@@ -132 +132 @@
     else
     {
+        /** @todo We should probably be using thread_affinity_set() here, see
+         *        cpu_online() code. */
         /*
          * We're not on the target CPU, schedule (synchronous) the event notification callback