Changeset 54409 in vbox

Timestamp:

Feb 24, 2015 2:07:23 AM (10 years ago)

Author:

vboxsync

Message:

SUPDrvGip.cpp: Use RTMpOnPair.

File:

• trunk/src/VBox/HostDrivers/Support/SUPDrvGip.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrvGip.cpp

@@ -3764 +3764 @@
     {
         /*
-         * Initialize data package for the RTMpOnAll callback.
+         * Initialize data package for the RTMpOnPair callback.
          */
         PSUPDRVGIPTSCDELTARGS pArgs = (PSUPDRVGIPTSCDELTARGS)RTMemAllocZ(sizeof(*pArgs));
@@ -3790 +3790 @@
             {
                 /*
-                 * Fire TSC-read workers on all CPUs but only synchronize between master
-                 * and one worker to ease memory contention.
+                 * Do the RTMpOnPair call.  We reset i64TSCDelta first so we
+                 * and supdrvMeasureTscDeltaCallback can use it as a success check.
                  */
+                /** @todo Store the i64TSCDelta result in pArgs first?   Perhaps deals with
+                 *        that when doing the restart loop reorg.  */
                 ASMAtomicWriteS64(&pGipCpuWorker->i64TSCDelta, INT64_MAX);
-
-                /** @todo Add RTMpOnPair and replace this ineffecient broadcast IPI.  */
-                rc = RTMpOnAll(supdrvMeasureTscDeltaCallback, pArgs, NULL);
+                rc = RTMpOnPair(pGipCpuMaster->idCpu, pGipCpuWorker->idCpu, RTMPON_F_CONCURRENT_EXEC,
+                                supdrvMeasureTscDeltaCallback, pArgs, NULL);
                 if (RT_SUCCESS(rc))
                 {