Changeset 54701 in vbox for trunk

Timestamp:

Mar 9, 2015 4:42:11 PM (10 years ago)

Author:

vboxsync

Message:

VMM/GIM: nits.

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/GIMAllHv.cpp (modified) (2 diffs)
• VMMR3/GIMHv.cpp (modified) (1 diff)
• VMMR3/GIMMinimal.cpp (modified) (1 diff)
• include/GIMHvInternal.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/GIMAllHv.cpp

@@ -82 +82 @@
  * MSR read handler for Hyper-V.
  *
- * @returns Strict VBox status code like CPUMQueryGuestMsr.
+ * @returns Strict VBox status code like CPUMQueryGuestMsr().
  * @retval  VINF_CPUM_R3_MSR_READ
  * @retval  VERR_CPUM_RAISE_GP_0
@@ -170 +170 @@
  * MSR write handler for Hyper-V.
  *
- * @returns Strict VBox status code like CPUMSetGuestMsr.
+ * @returns Strict VBox status code like CPUMSetGuestMsr().
  * @retval  VINF_CPUM_R3_MSR_WRITE
  * @retval  VERR_CPUM_RAISE_GP_0

trunk/src/VBox/VMM/VMMR3/GIMHv.cpp

@@ -320 +320 @@
  *
  * @param   pVM     Pointer to the VM.
+ * @thread EMT(0).
  */
 VMMR3_INT_DECL(void) gimR3HvReset(PVM pVM)
 {
+    VM_ASSERT_EMT0(pVM);
+
     /*
      * Unmap MMIO2 pages that the guest may have setup.

trunk/src/VBox/VMM/VMMR3/GIMMinimal.cpp

@@ -107 +107 @@
 
 /**
- * Applies relocations to data and code managed by this component. This function
- * will be called at init and whenever the VMM need to relocate itself inside
- * the GC.
+ * Applies relocations to data and code managed by this component.
+ *
+ * This function will be called at init and whenever the VMM need to relocate
+ * itself inside the GC.
  *
  * @param   pVM         Pointer to the VM.

trunk/src/VBox/VMM/include/GIMHvInternal.h

@@ -452 +452 @@
 
 /**
- * GIM Hyper-V VM Instance data.
+ * GIM Hyper-V VM instance data.
  * Changes to this must checked against the padding of the gim union in VM!
  */
 typedef struct GIMHV
 {
+    /** @name MSRs.
+     *  { */
     /** Guest OS identity MSR. */
     uint64_t                    u64GuestOsIdMsr;
@@ -463 +465 @@
     /** Reference TSC page MSR. */
     uint64_t                    u64TscPageMsr;
-
+    /** @}  */
+
+    /** @name CPUID features.
+     *  { */
     /** Basic features. */
     uint32_t                    uBaseFeat;
     /** Partition flags. */
     uint32_t                    uPartFlags;
-    /** Power management features. */
+    /** Power management. */
     uint32_t                    uPowMgmtFeat;
-    /** Miscellaneous features. */
+    /** Miscellaneous. */
     uint32_t                    uMiscFeat;
     /** Hypervisor hints to the guest. */
@@ -476 +481 @@
     /** Hypervisor capabilities. */
     uint32_t                    uHyperCaps;
+    /** @} */
 
     /** Per-VM R0 Spinlock for protecting EMT writes to the TSC page. */