Changeset 54702 in vbox for trunk/src/VBox

Timestamp:

Mar 9, 2015 5:25:28 PM (10 years ago)

Author:

vboxsync

Message:

Additions/VBoxService: don't spam the log file with messages ignoring privileged users

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp

@@ -707 +707 @@
                                     struct passwd *ppwEntry = getpwuid(uid);
                                     if (   ppwEntry
-                                        && ppwEntry->pw_uid >= uid_min /* Only respect users, not daemons etc. */
                                         && ppwEntry->pw_name)
                                     {
-                                        VBoxServiceVerbose(4, "ConsoleKit: session '%s' -> %s (uid: %RU32)\n",
-                                                           *ppszCurSession, ppwEntry->pw_name, uid);
-
-                                        bool fFound = false;
-                                        for (uint32_t i = 0; i < cUsersInList && !fFound; i++)
-                                            fFound = strcmp(papszUsers[i], ppwEntry->pw_name) == 0;
-
-                                        if (!fFound)
+                                        if (ppwEntry->pw_uid >= uid_min /* Only respect users, not daemons etc. */)
                                         {
-                                            VBoxServiceVerbose(4, "ConsoleKit: adding user \"%s\" to list\n",
-                                                               ppwEntry->pw_name);
-
-                                            rc = RTStrDupEx(&papszUsers[cUsersInList], (const char *)ppwEntry->pw_name);
-                                            if (RT_FAILURE(rc))
-                                                break;
-                                            cUsersInList++;
+                                            VBoxServiceVerbose(4, "ConsoleKit: session '%s' -> %s (uid: %RU32)\n",
+                                                               *ppszCurSession, ppwEntry->pw_name, uid);
+
+                                            bool fFound = false;
+                                            for (uint32_t i = 0; i < cUsersInList && !fFound; i++)
+                                                fFound = strcmp(papszUsers[i], ppwEntry->pw_name) == 0;
+
+                                            if (!fFound)
+                                            {
+                                                VBoxServiceVerbose(4, "ConsoleKit: adding user \"%s\" to list\n",
+                                                                   ppwEntry->pw_name);
+
+                                                rc = RTStrDupEx(&papszUsers[cUsersInList], (const char *)ppwEntry->pw_name);
+                                                if (RT_FAILURE(rc))
+                                                    break;
+                                                cUsersInList++;
+                                            }
                                         }
+                                        /* else silently ignore the user */
                                     }
                                     else