Changeset 54718 in vbox

Timestamp:

Mar 11, 2015 4:14:41 PM (10 years ago)

Author:

vboxsync

Message:

VMM: VMMR0ThreadCtxHooksDeregister returns void, further simplified HM_[DISABLE|RESTORE]_PREEMPT_IF_NEEDED() a bit.

Location:

trunk

Files:

• include/VBox/vmm/hm.h (modified) (1 diff)
• include/VBox/vmm/vmm.h (modified) (1 diff)
• src/VBox/VMM/VMMR0/VMMR0.cpp (modified) (2 diffs)

trunk/include/VBox/vmm/hm.h

@@ -182 +182 @@
 # define HM_DISABLE_PREEMPT_IF_NEEDED() \
     RTTHREADPREEMPTSTATE PreemptStateInternal = RTTHREADPREEMPTSTATE_INITIALIZER; \
-    bool fPreemptDisabledInternal = false; \
-    if (RTThreadPreemptIsEnabled(NIL_RTTHREAD)) \
-    { \
-        Assert(VMMR0ThreadCtxHooksAreRegistered(pVCpu)); \
-        RTThreadPreemptDisable(&PreemptStateInternal); \
-        fPreemptDisabledInternal = true; \
-    } else do { } while (0)
-
-# define HM_RESTORE_PREEMPT_IF_NEEDED() \
-    do \
-    { \
-        if (fPreemptDisabledInternal) \
-            RTThreadPreemptRestore(&PreemptStateInternal); \
-    } while (0)
+    Assert(!RTThreadPreemptIsEnabled(NIL_RTTHREAD) || VMMR0ThreadCtxHooksAreRegistered(pVCpu)); \
+    RTThreadPreemptDisable(&PreemptStateInternal);
 #else
 # define HM_DISABLE_PREEMPT_IF_NEEDED() \
     RTTHREADPREEMPTSTATE PreemptStateInternal = RTTHREADPREEMPTSTATE_INITIALIZER; \
     RTThreadPreemptDisable(&PreemptStateInternal);
-
+#endif /* VBOX_STRICT */
 # define HM_RESTORE_PREEMPT_IF_NEEDED() do { RTThreadPreemptRestore(&PreemptStateInternal); } while(0)
-#endif /* VBOX_STRICT */
+
 
 VMMR0_INT_DECL(int)             HMR0SetupVM(PVM pVM);

trunk/include/VBox/vmm/vmm.h

@@ -513 +513 @@
 VMMR0DECL(bool)      VMMR0ThreadCtxHooksAreCreated(PVMCPU pVCpu);
 VMMR0DECL(int)       VMMR0ThreadCtxHooksRegister(PVMCPU pVCpu, PFNRTTHREADCTXHOOK pfnHook);
-VMMR0DECL(int)       VMMR0ThreadCtxHooksDeregister(PVMCPU pVCpu);
+VMMR0DECL(void)      VMMR0ThreadCtxHooksDeregister(PVMCPU pVCpu);
 VMMR0DECL(bool)      VMMR0ThreadCtxHooksAreRegistered(PVMCPU pVCpu);
 

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -503 +503 @@
  * Deregisters the thread-context hook for this VCPU.
  *
- * @returns VBox status code.
  * @param   pVCpu       Pointer to the VMCPU.
  *
  * @thread  EMT(pVCpu)
  */
-VMMR0DECL(int) VMMR0ThreadCtxHooksDeregister(PVMCPU pVCpu)
+VMMR0DECL(void) VMMR0ThreadCtxHooksDeregister(PVMCPU pVCpu)
 {
     /* Clear the VCPU <-> host CPU mapping as we've left HM context. See @bugref{7726} comment #19. */
@@ -517 +516 @@
         Assert(!RTThreadPreemptIsEnabled(NIL_RTTHREAD));
         int rc = RTThreadCtxHooksDeregister(pVCpu->vmm.s.hR0ThreadCtx);
-        AssertRCReturn(rc, rc);
-    }
-    return VINF_SUCCESS;
+        AssertRC(rc);
+    }
 }