Changeset 54761 in vbox for trunk

Timestamp:

Mar 13, 2015 9:35:30 PM (10 years ago)

Author:

vboxsync

Message:

PATM: Only fix up constants when loading state.

Location:

trunk/src/VBox/VMM

Files:

• VMMR3/PATM.cpp (modified) (2 diffs)
• VMMR3/PATMPatch.cpp (modified) (4 diffs)
• VMMR3/PATMSSM.cpp (modified) (7 diffs)
• include/PATMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/PATM.cpp

@@ -763 +763 @@
         {
         case FIXUP_ABSOLUTE_IN_PATCH_ASM_TMPL:
-            Assert(pRec->pDest == pRec->pSource);
+            Assert(pRec->pDest == pRec->pSource); Assert(PATM_IS_FIXUP_TYPE(pRec->pSource));
             Log(("Absolute patch template fixup type %#x at %RHv -> %RHv at %RRv\n", pRec->pSource, *(RTRCUINTPTR *)pRec->pRelocPos, *(RTRCINTPTR*)pRec->pRelocPos + delta, pRec->pRelocPos));
             *(RTRCUINTPTR *)pRec->pRelocPos += delta;
@@ -916 +916 @@
             break;
         }
+
+        case FIXUP_CONSTANT_IN_PATCH_ASM_TMPL:
+            /* Only applicable when loading state. */
+            Assert(pRec->pDest == pRec->pSource);
+            Assert(PATM_IS_FIXUP_TYPE(pRec->pSource));
+            break;
 
         default:

trunk/src/VBox/VMM/VMMR3/PATMPatch.cpp

@@ -177 +177 @@
                  * A SAVED STATE WITH A DIFFERENT HYPERVISOR LAYOUT.
                  */
+                uint32_t uRelocType = FIXUP_ABSOLUTE_IN_PATCH_ASM_TMPL;
                 switch (pAsmRecord->aRelocs[i].uType)
                 {
@@ -353 +354 @@
                     /*
                      * The following fixups needs to be recalculated when loading saved state
-                     * Note! Earlier saved state versions had different hacks for detecting these.
+                     * Note! Earlier saved state versions had different hacks for detecting some of these.
                      */
                     case PATM_VM_FORCEDACTIONS:
@@ -367 +368 @@
                         dest = CPUMR3GetGuestCpuIdPatmArrayEndRCPtr(pVM);
                         break;
+
+                    case PATM_CPUID_STD_PTR: /* saved state only */
+                        dest = CPUMR3GetGuestCpuIdPatmStdRCPtr(pVM);
+                        break;
+                    case PATM_CPUID_EXT_PTR: /* saved state only */
+                        dest = CPUMR3GetGuestCpuIdPatmExtRCPtr(pVM);
+                        break;
+                    case PATM_CPUID_CENTAUR_PTR: /* saved state only */
+                        dest = CPUMR3GetGuestCpuIdPatmCentaurRCPtr(pVM);
+                        break;
+
+                    /*
+                     * The following fixups are constants that needs to be corrected when
+                     * loading saved state as these may change between VBox versions.
+                     */
                     case PATM_CPUID_ARRAY_ENTRY_SIZE:
                         dest = sizeof(CPUMCPUIDLEAF);
+                        uRelocType = FIXUP_CONSTANT_IN_PATCH_ASM_TMPL;
                         break;
                     case PATM_CPUID_UNKNOWN_METHOD:
                         dest = CPUMR3GetGuestCpuIdPatmUnknownLeafMethod(pVM);
-                        break;
-
-                    case PATM_CPUID_STD_PTR: /* saved state only */
-                        dest = CPUMR3GetGuestCpuIdPatmStdRCPtr(pVM);
-                        break;
-                    case PATM_CPUID_EXT_PTR: /* saved state only */
-                        dest = CPUMR3GetGuestCpuIdPatmExtRCPtr(pVM);
-                        break;
-                    case PATM_CPUID_CENTAUR_PTR: /* saved state only */
-                        dest = CPUMR3GetGuestCpuIdPatmCentaurRCPtr(pVM);
-                        break;
-
+                        uRelocType = FIXUP_CONSTANT_IN_PATCH_ASM_TMPL;
+                        break;
+
+                    /*
+                     * Unknown fixup.
+                     */
                     default:
+                        AssertReleaseMsgFailed(("Unknown fixup: %#x\n", pAsmRecord->aRelocs[i].uType));
                         dest = PATM_ILLEGAL_DESTINATION;
-                        AssertReleaseFailed();
                         break;
                 }
@@ -393 +404 @@
                 if (pAsmRecord->aRelocs[i].uType < PATM_NO_FIXUP)
                 {
-                    patmPatchAddReloc32(pVM, pPatch, &pPB[j], FIXUP_ABSOLUTE_IN_PATCH_ASM_TMPL,
+                    patmPatchAddReloc32(pVM, pPatch, &pPB[j], uRelocType,
                                         pAsmRecord->aRelocs[i].uType /*pSources*/, pAsmRecord->aRelocs[i].uType /*pDest*/);
                 }

trunk/src/VBox/VMM/VMMR3/PATMSSM.cpp

@@ -142 +142 @@
 *   Internal Functions                                                         *
 *******************************************************************************/
-static void patmCorrectFixup(PVM pVM, unsigned ulSSMVersion, PATM &patmInfo, PPATCHINFO pPatch, PRELOCREC pRec, int32_t offset, RTRCPTR *pFixup);
+static int patmCorrectFixup(PVM pVM, unsigned ulSSMVersion, PATM &patmInfo, PPATCHINFO pPatch, PRELOCREC pRec,
+                            int32_t offset, RTRCPTR *pFixup);
+
 
 /*******************************************************************************
@@ -981 +983 @@
                     }
 
-                    patmCorrectFixup(pVM, uVersion, patmInfo, &pPatchRec->patch, &rec, offset, pFixup);
+                    rc = patmCorrectFixup(pVM, uVersion, patmInfo, &pPatchRec->patch, &rec, offset, pFixup);
+                    AssertRCReturn(rc, rc);
                 }
 
@@ -1067 +1070 @@
 
         /* Correct fixups that refer to PATM structures in the hypervisor region (their addresses might have changed). */
-        patmCorrectFixup(pVM, uVersion, patmInfo, &pVM->patm.s.pGlobalPatchRec->patch, pRec, offset, pFixup);
+        rc = patmCorrectFixup(pVM, uVersion, patmInfo, &pVM->patm.s.pGlobalPatchRec->patch, pRec, offset, pFixup);
+        AssertRCReturn(rc, rc);
     }
 
@@ -1095 +1099 @@
  * @param   pFixup          Fixup address
  */
-static void patmCorrectFixup(PVM pVM, unsigned uVersion, PATM &patmInfo, PPATCHINFO pPatch, PRELOCREC pRec,
-                             int32_t offset, RTRCPTR *pFixup)
+static int patmCorrectFixup(PVM pVM, unsigned uVersion, PATM &patmInfo, PPATCHINFO pPatch, PRELOCREC pRec,
+                            int32_t offset, RTRCPTR *pFixup)
 {
     int32_t delta = pVM->patm.s.pPatchMemGC - patmInfo.pPatchMemGC;
@@ -1363 +1367 @@
                     *pFixup = CPUMR3GetGuestCpuIdPatmArrayEndRCPtr(pVM);
                     break;
-                case PATM_CPUID_ARRAY_ENTRY_SIZE:
-                    *pFixup = sizeof(CPUMCPUIDLEAF);
-                    break;
-                case PATM_CPUID_UNKNOWN_METHOD:
-                    *pFixup = CPUMR3GetGuestCpuIdPatmUnknownLeafMethod(pVM);
-                    break;
                 case PATM_CPUID_STD_PTR: /* Saved again patches only. */
                     *pFixup = CPUMR3GetGuestCpuIdPatmStdRCPtr(pVM);
@@ -1378 +1376 @@
                     *pFixup = CPUMR3GetGuestCpuIdPatmCentaurRCPtr(pVM);
                     break;
+            }
+        }
+        /*
+         * Constant that may change between VM version needs fixing up.
+         */
+        else if (pRec->uType == FIXUP_CONSTANT_IN_PATCH_ASM_TMPL)
+        {
+            AssertLogRelReturn(uVersion > PATM_SAVED_STATE_VERSION_NO_RAW_MEM, VERR_SSM_DATA_UNIT_FORMAT_CHANGED);
+            Assert(pRec->pSource == pRec->pDest); Assert(PATM_IS_FIXUP_TYPE(pRec->pSource));
+            switch (pRec->pSource)
+            {
+                case PATM_CPUID_ARRAY_ENTRY_SIZE:
+                    *pFixup = sizeof(CPUMCPUIDLEAF);
+                    break;
+                case PATM_CPUID_UNKNOWN_METHOD:
+                    *pFixup = CPUMR3GetGuestCpuIdPatmUnknownLeafMethod(pVM);
+                    break;
+                default:
+                    AssertLogRelMsgFailed(("Unknown FIXUP_CONSTANT_IN_PATCH_ASM_TMPL fixup: %#x\n", pRec->pSource));
+                    return VERR_SSM_DATA_UNIT_FORMAT_CHANGED;
             }
         }
@@ -1480 +1498 @@
     }
 }
+    return VINF_SUCCESS;
 }
 

trunk/src/VBox/VMM/include/PATMInternal.h

@@ -114 +114 @@
  * as FIXUP_ABSOLUTE. */
 #define FIXUP_ABSOLUTE_IN_PATCH_ASM_TMPL   3
+/** Constant value that only needs fixing up when loading state.  Structure
+ * size, member offset, or similar.  The source and destination address are set
+ * like for FIXUP_ABSOLUTE_IN_PATCH_ASM_TMPL.  */
+#define FIXUP_CONSTANT_IN_PATCH_ASM_TMPL   4
 /** @} */