Changeset 54851 in vbox

Timestamp:

Mar 19, 2015 6:44:35 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

99056

Message:

Audio/CoreAudio: Better fix for the leak, addresses both code paths taken in the method

File:

• trunk/src/VBox/Devices/Audio/DrvHostCoreAudio.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DrvHostCoreAudio.cpp

@@ -607 +607 @@
             {
                 LogFlowFunc(("Failed rendering audio data (%RI32)\n", err));
-                RTMemFree(pStreamIn->bufferList.mBuffers[0].mData);
-                pStreamIn->bufferList.mBuffers[0].mData = NULL;
                 rc = VERR_IO_GEN_FAILURE; /** @todo Improve this. */
                 break;
@@ -639 +637 @@
         }
 
-        if (pStreamIn->bufferList.mBuffers[0].mData)
-        {
-            RTMemFree(pStreamIn->bufferList.mBuffers[0].mData);
-            pStreamIn->bufferList.mBuffers[0].mData = NULL;
-        }
-
     } while (0);
+
+    if (pStreamIn->bufferList.mBuffers[0].mData)
+    {
+        RTMemFree(pStreamIn->bufferList.mBuffers[0].mData);
+        pStreamIn->bufferList.mBuffers[0].mData = NULL;
+    }
 
     return err;