Changeset 54945 in vbox for trunk/src/VBox/Main

Timestamp:

Mar 25, 2015 3:30:20 PM (10 years ago)

Author:

vboxsync

Message:

Main/Medium: release media locks by destroying tasks before sending task completion notifications (see #7763)

File:

• trunk/src/VBox/Main/src-server/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -769 +769 @@
     HRESULT rc = pTask->handler();
 
-    /* complete the progress if run asynchronously */
+    /*
+     * save the progress reference if run asynchronously, since we want to
+     * destroy the task before we send out the completion notification.
+     * see @bugref{7763}
+     */
+    ComObjPtr<Progress> pProgress;
     if (pTask->isAsync())
-        if (!pTask->mProgress.isNull())
-            pTask->mProgress->i_notifyComplete(rc);
+        pProgress = pTask->mProgress;
 
     /* pTask is no longer needed, delete it. */
     delete pTask;
+
+    /* complete the progress if run asynchronously */
+    if (!pProgress.isNull())
+        pProgress->i_notifyComplete(rc);
 
     LogFlowFunc(("rc=%Rhrc\n", rc));