Changeset 5519 in vbox for trunk/src/VBox/Runtime/common/misc

Timestamp:

Oct 26, 2007 4:04:08 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

25734

Message:

Runtime: Fixed memory leaks found by valgrind.

File:

• trunk/src/VBox/Runtime/common/misc/thread.cpp (modified) (6 diffs)

trunk/src/VBox/Runtime/common/misc/thread.cpp

@@ -242 +242 @@
             rtThreadInsert(pThread, NativeThread);
             pThread->enmState = RTTHREADSTATE_RUNNING;
+            rtThreadRelease(pThread);
         }
     }
@@ -686 +687 @@
     PRTTHREADINT pThread = rtThreadGet(Thread);
     if (pThread)
-        return (RTNATIVETHREAD)pThread->Core.Key;
+    {
+        RTNATIVETHREAD NativeThread = (RTNATIVETHREAD)pThread->Core.Key;
+        rtThreadRelease(pThread);
+        return NativeThread;
+    }
     return NIL_RTNATIVETHREAD;
 }
@@ -702 +707 @@
     PRTTHREADINT pThread = rtThreadGetByNative(NativeThread);
     if (pThread)
-    {
-        rtThreadRelease(pThread);
         return pThread;
-    }
     return NIL_RTTHREAD;
 }
@@ -723 +725 @@
         PRTTHREADINT pThread = rtThreadGet(Thread);
         if (pThread)
-            return pThread->szName;
+        {
+            const char *szName = pThread->szName;
+            rtThreadRelease(pThread);
+            return szName;
+        }
     }
     return NULL;
@@ -741 +747 @@
         return NULL;
     PRTTHREADINT pThread = rtThreadGet(Thread);
-    return pThread ?  pThread->szName : NULL;
+    if (pThread)
+    {
+        const char *szName = pThread->szName;
+        rtThreadRelease(pThread);
+        return szName;
+    }
+    return NULL;
 }
 
@@ -772 +784 @@
     pThread->szName[cchName] = '\0';    /* paranoia */
     memcpy(pThread->szName, pszName, cchName);
+    rtThreadRelease(pThread);
     return VINF_SUCCESS;
 }