Changeset 5522 in vbox for trunk/src/libs/xpcom18a4/xpcom/base

Timestamp:

Oct 26, 2007 5:21:00 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

25742

Message:

XPCOM: Fixed memory errors and leaks found by valgrind.

File:

• trunk/src/libs/xpcom18a4/xpcom/base/nsExceptionService.cpp (modified) (2 diffs)

trunk/src/libs/xpcom18a4/xpcom/base/nsExceptionService.cpp

@@ -84 +84 @@
 #ifdef NS_DEBUG
   inline nsrefcnt ReleaseQuiet() {
-      nsAutoOwningThread old = _mOwningThread;
-      _mOwningThread = nsAutoOwningThread();
-      nsrefcnt ref = Release();
+    // shut up NS_ASSERT_OWNINGTHREAD (see explaination below)
+    nsAutoOwningThread old = _mOwningThread;
+    _mOwningThread = nsAutoOwningThread();
+    nsrefcnt ref = Release();
+    NS_ASSERTION(ref == 0, "the object is still referenced by other threads while it shouldn't");
+    if (ref != 0)
       _mOwningThread = old;
-      return ref;
+    return ref;
   }
 #else  
@@ -103 +106 @@
 #endif
 
-// Note this object is single threaded - the service itself ensures
-// one per thread.
-// Exceptions are DropAllThreads (called on the thread shutting down xpcom)
-// and ThreadDestruct (called after xpcom destroyed the internal thread struct,
-// so that PR_GetCurrentThread() will create a new one from scratch which will
-// obviously not match the old one stored in the instance on creation). Since
-// these NS_CheckThreadSafe() assertions are quite annoying in the debug build,
-// we use a special ReleaseQuiet() mehtod in DoDropThread() to shut them up.
+// Note: the nsExceptionManager object is single threaded - the exception
+// service itself ensures one per thread. However, there are two methods that
+// may be called on foreign threads: DropAllThreads (called on the thread
+// shutting down xpcom) and ThreadDestruct (called after xpcom destroyed the
+// internal thread struct, so that PR_GetCurrentThread() will create a new one
+// from scratch which will obviously not match the old one stored in the
+// instance on creation). In both cases, there should be no other threads
+// holding objects (i.e. it's thread-safe to call them), but
+// NS_CheckThreadSafe() assertions will still happen and yell in the debug
+// build. Since it is quite annoying, we use a special ReleaseQuiet() mehtod
+// in DoDropThread() to shut them up.
 NS_IMPL_ISUPPORTS1(nsExceptionManager, nsIExceptionManager)