Changeset 55253 in vbox

Timestamp:

Apr 14, 2015 2:56:38 PM (10 years ago)

Author:

vboxsync

Message:

memcache.cpp: Enabled the free list (unused).

File:

• trunk/src/VBox/Runtime/common/alloc/memcache.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/alloc/memcache.cpp

@@ -226 +226 @@
     pThis->pFreeTop         = NULL;
 
-#if 1 /* should be fixed now, enable shortly... */
-    /** @todo
-     * Here is a puzzler (or maybe I'm just blind), the free list code breaks
-     * badly on my macbook pro (i7) (32-bit).
-     *
-     * I tried changing the reads from unordered to ordered to no avail.  Then I
-     * tried optimizing the code with the ASMAtomicCmpXchgExPtr function to
-     * avoid some reads - no change. Inserting pause instructions did nothing
-     * (as expected).  The only thing which seems to make a difference is
-     * reading the pFreeTop pointer twice in the free code... This is weird or I'm
-     * overlooking something..
-     *
-     * No time to figure it out, so I'm disabling the broken code paths for
-     * now. */
-    pThis->fUseFreeList = false;
-#endif
-
     *phMemCache = pThis;
     return VINF_SUCCESS;