Changeset 55514 in vbox for trunk/src/VBox

Timestamp:

Apr 29, 2015 11:46:33 AM (10 years ago)

Author:

vboxsync

Message:

DnD: Make source/target blocksizes configurable.

Location:

trunk/src/VBox/Main

Files:

• include/GuestDnDSourceImpl.h (modified) (1 diff)
• src-client/GuestDnDSourceImpl.cpp (modified) (2 diffs)
• src-client/GuestDnDTargetImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/GuestDnDSourceImpl.h

@@ -87 +87 @@
     int i_receiveRawData(PRECVDATACTX pCtx);
     int i_receiveURIData(PRECVDATACTX pCtx);
+    int i_updateProcess(PRECVDATACTX pCtx, uint32_t cbDataAdd);
 
 protected:
 
-    int i_updateProcess(PRECVDATACTX pCtx, uint32_t cbDataAdd);
+    /** Maximum data block size (in bytes) the source can handle. */
+    uint32_t m_cbBlockSize;
 };
 

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -102 +102 @@
 HRESULT GuestDnDSource::FinalConstruct(void)
 {
+    /* Set the maximum block size this source can handle to 64K. This always has
+     * been hardcoded until now. */
+    /* Note: Never ever rely on information from the guest; the host dictates what and
+     *       how to do something, so try to negogiate a sensible value here later. */
+    m_cbBlockSize = _64K; /** @todo Make this configurable. */
+
     LogFlowThisFunc(("\n"));
     return BaseFinalConstruct();
@@ -445 +451 @@
     {
         if (   cbData > cbTotalSize
-            || cbData > _64K) /** @todo Make this configurable? */
+            || cbData > m_cbBlockSize)
         {
             LogFlowFunc(("Data sizes invalid: cbData=%RU32, cbTotalSize=%RU64\n", cbData, cbTotalSize));

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -111 +111 @@
     /* Note: Never ever rely on information from the guest; the host dictates what and
      *       how to do something, so try to negogiate a sensible value here later. */
-    m_cbBlockSize = _32K; /** @todo Make this configurable. */
+    m_cbBlockSize = _64K; /** @todo Make this configurable. */
 
     LogFlowThisFunc(("\n"));