Changeset 55531 in vbox

Timestamp:

Apr 29, 2015 6:06:09 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

99890

Message:

Main,VBoxService: Added ProcessCreateFlag_UnquotedArguments.

Location:

trunk

Files:

• include/VBox/HostServices/GuestControlSvc.h (modified) (3 diffs)
• src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp (modified) (8 diffs)
• src/VBox/Main/idl/VirtualBox.xidl (modified) (2 diffs)

trunk/include/VBox/HostServices/GuestControlSvc.h

@@ -106 +106 @@
 };
 
+/** @todo r=bird: Most defines in this file needs to be scoped a little
+ *        better!  For instance INPUT_FLAG_NONE is very generic. */
+
 /**
  * Input flags, set by the host. This is needed for
@@ -133 +136 @@
 #define DIRREMOVE_FLAG_VALID_MASK           UINT32_C(0x00000003)
 
-/**
- * Guest process creation flags.
- * Note: Has to match Main's ProcessCreateFlag_* flags!
- */
-#define EXECUTEPROCESSFLAG_NONE             0x0
+/** @name EXECUTEPROCESSFLAG_XXX Guest process creation flags.
+ * @note Has to match Main's ProcessCreateFlag_* flags!
+ */
+#define EXECUTEPROCESSFLAG_NONE             UINT32_C(0x0)
 #define EXECUTEPROCESSFLAG_WAIT_START       RT_BIT(0)
 #define EXECUTEPROCESSFLAG_IGNORE_ORPHANED  RT_BIT(1)
@@ -145 +147 @@
 #define EXECUTEPROCESSFLAG_WAIT_STDERR      RT_BIT(5)
 #define EXECUTEPROCESSFLAG_EXPAND_ARGUMENTS RT_BIT(6)
+#define EXECUTEPROCESSFLAG_UNQUOTED_ARGS    RT_BIT(7)
+/** @} */
 
 /**

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp

@@ -1065 +1065 @@
  * @param  pszArgv0         First argument (argv0), either original or modified version.  Optional.
  * @param  papszArgs        Original argv command line from the host, starting at argv[1].
+ * @param  fFlags           The process creation flags pass to us from the host.
  * @param  ppapszArgv       Pointer to a pointer with the new argv command line.
  *                          Needs to be freed with RTGetOptArgvFree.
  */
-static int gstcntlProcessAllocateArgv(const char *pszArgv0,
-                                      const char * const *papszArgs,
-                                      bool fExpandArgs, char ***ppapszArgv)
+static int gstcntlProcessAllocateArgv(const char *pszArgv0, const char * const *papszArgs, uint32_t fFlags,
+                                      char ***ppapszArgv)
 {
     AssertPtrReturn(ppapszArgv, VERR_INVALID_POINTER);
 
-    VBoxServiceVerbose(3, "GstCntlProcessPrepareArgv: pszArgv0=%p, papszArgs=%p, fExpandArgs=%RTbool, ppapszArgv=%p\n",
-                       pszArgv0, papszArgs, fExpandArgs, ppapszArgv);
+    VBoxServiceVerbose(3, "GstCntlProcessPrepareArgv: pszArgv0=%p, papszArgs=%p, fFlags=%#x, ppapszArgv=%p\n",
+                       pszArgv0, papszArgs, fFlags, ppapszArgv);
 
     int rc = VINF_SUCCESS;
@@ -1096 +1096 @@
 #endif
 
-    size_t i = 0; /* Keep the argument counter in scope for cleaning up on failure. */
-
-    rc = RTStrDupEx(&papszNewArgv[0], pszArgv0);
+
+    /* HACK ALERT! Since we still don't allow the user to really specify the first
+                   argument separately from the executable image, we have to fudge
+                   a little in the unquoted argument case to deal with executables
+                   containing spaces. */
+    /** @todo Fix the stupid host/guest protocol so the user can do this for us! */
+    if (   !(fFlags & EXECUTEPROCESSFLAG_UNQUOTED_ARGS)
+        || !strpbrk(pszArgv0, " \t\n\r")
+        || pszArgv0[0] == '"')
+        rc = RTStrDupEx(&papszNewArgv[0], pszArgv0);
+    else
+    {
+        size_t cchArgv0 = strlen(pszArgv0);
+        rc = RTStrAllocEx(&papszNewArgv[0], 1 + cchArgv0 + 1 + 1);
+        if (RT_SUCCESS(rc))
+        {
+            char *pszDst = papszNewArgv[0];
+            *pszDst++ = '"';
+            memcpy(pszDst, pszArgv0, cchArgv0);
+            pszDst += cchArgv0;
+            *pszDst++ = '"';
+            *pszDst   = '\0';
+        }
+    }
     if (RT_SUCCESS(rc))
     {
-        for (; i < cArgs; i++)
+        size_t i;
+        for (i = 0; i < cArgs; i++)
         {
             char *pszArg;
 #if 0 /* Arguments expansion -- untested. */
-            if (fExpandArgs)
-            {
+            if (fFlags & EXECUTEPROCESSFLAG_EXPAND_ARGUMENTS)
+            {
+/** @todo r=bird: If you want this, we need a generic implementation, preferably in RTEnv or somewhere like that.  The marking
+ * up of the variables must be the same on all platforms.  */
                 /* According to MSDN the limit on older Windows version is 32K, whereas
                  * Vista+ there are no limits anymore. We still stick to 4K. */
@@ -1136 +1160 @@
 
             *ppapszArgv = papszNewArgv;
-        }
-    }
-
-    if (RT_FAILURE(rc))
-    {
-        for (i; i > 0; i--)
+            return VINF_SUCCESS;
+        }
+
+        /* Failed, bail out. */
+        for (; i > 0; i--)
             RTStrFree(papszNewArgv[i]);
-        RTMemFree(papszNewArgv);
-    }
-
+    }
+    RTMemFree(papszNewArgv);
     return rc;
 }
@@ -1239 +1261 @@
     char szExecExp[RTPATH_MAX];
 
-    /* Do we need to expand environment variables in arguments? */
-    bool fExpandArgs = (fFlags & EXECUTEPROCESSFLAG_EXPAND_ARGUMENTS) ? true  : false;
-
 #ifdef RT_OS_WINDOWS
     /*
@@ -1295 +1314 @@
         {
             char **papszArgsExp;
-            rc = gstcntlProcessAllocateArgv(szSysprepCmd /* argv0 */, papszArgs,
-                                            fExpandArgs, &papszArgsExp);
+            rc = gstcntlProcessAllocateArgv(szSysprepCmd /* argv0 */, papszArgs, fFlags, &papszArgsExp);
             if (RT_SUCCESS(rc))
             {
@@ -1336 +1354 @@
     {
         char **papszArgsExp;
+        /** @todo r-bird: pszExec != argv[0]! When are you going to get that?!? How many
+         * times does this need to be pointed out?  HOST/GUEST INTERFACE IS MISDESIGNED! */
         rc = gstcntlProcessAllocateArgv(pszExec /* Always use the unmodified executable name as argv0. */,
                                         papszArgs /* Append the rest of the argument vector (if any). */,
-                                        fExpandArgs, &papszArgsExp);
+                                        fFlags, &papszArgsExp);
         if (RT_FAILURE(rc))
         {
@@ -1353 +1373 @@
                 if (fFlags & EXECUTEPROCESSFLAG_NO_PROFILE)
                     uProcFlags |= RTPROC_FLAGS_NO_PROFILE;
+                if (fFlags & EXECUTEPROCESSFLAG_UNQUOTED_ARGS)
+                    uProcFlags |= RTPROC_FLAGS_UNQUOTED_ARGS;
             }
 
@@ -1591 +1613 @@
                                 bool fNeedsImpersonation = !(pProcess->pSession->uFlags & VBOXSERVICECTRLSESSION_FLAG_FORK);
 
-                                rc = gstcntlProcessCreateProcess(pProcess->StartupInfo.szCmd, papszArgs, hEnv, pProcess->StartupInfo.uFlags,
+                                rc = gstcntlProcessCreateProcess(pProcess->StartupInfo.szCmd, papszArgs, hEnv,
+                                                                 pProcess->StartupInfo.uFlags,
                                                                  phStdIn, phStdOut, phStdErr,
                                                                  fNeedsImpersonation ? pProcess->StartupInfo.szUser : NULL,

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -10217 +10217 @@
     <desc>
       Guest process execution flags.
+      <note>The values are passed to the guest additions, so its not possible
+            to change (move) or reuse values.here.  See EXECUTEPROCESSFLAG_XXX
+            in GuestControlSvc.h.</note>
     </desc>
 
@@ -10243 +10246 @@
     <const name="ExpandArguments"           value="64">
       <desc>Expands environment variables in process arguments.</desc>
+    </const>
+    <const name="UnquotedArguments"         value="128">
+      <desc>Work around for Windows and OS/2 applications not following normal
+        argument quoting and escaping rules. The arguments are passed to the
+        application without any extra quoting, just a single space between each.
+        <note>Present since VirtualBox 4.3.28 and 5.0 beta 3.</note>
+      </desc>
     </const>
   </enum>