Changeset 55827 in vbox for trunk

Timestamp:

May 12, 2015 1:31:09 PM (10 years ago)

Author:

vboxsync

Message:

FE/Qt: 7840: Allow attachment hot-plugging for USB storage controller.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -1203 +1203 @@
                     ControllerItem *ctr = static_cast <ControllerItem*> (item);
                     CSystemProperties sp = vboxGlobal().virtualBox().GetSystemProperties();
-                    switch (m_configurationAccessLevel)
+                    const bool fIsMoreAttachmentsPossible = (ULONG)rowCount(aIndex) <
+                                                            (sp.GetMaxPortCountForStorageBus(ctr->ctrBusType()) *
+                                                             sp.GetMaxDevicesPerPortForStorageBus(ctr->ctrBusType()));
+                    if (fIsMoreAttachmentsPossible)
                     {
-                        case ConfigurationAccessLevel_Full: return ((uint)rowCount(aIndex) < sp.GetMaxPortCountForStorageBus(ctr->ctrBusType()) *
-                                                                                             sp.GetMaxDevicesPerPortForStorageBus(ctr->ctrBusType()));
-                        case ConfigurationAccessLevel_Runtime: return (ctr->ctrBusType() == KStorageBus_SATA) &&
-                                                                      ((uint)rowCount(aIndex) < ctr->portCount());
-                        default: break;
+                        switch (m_configurationAccessLevel)
+                        {
+                            case ConfigurationAccessLevel_Full:
+                                return true;
+                            case ConfigurationAccessLevel_Runtime:
+                            {
+                                switch (ctr->ctrBusType())
+                                {
+                                    case KStorageBus_USB:
+                                        return true;
+                                    case KStorageBus_SATA:
+                                        return (uint)rowCount(aIndex) < ctr->portCount();
+                                    default:
+                                        break;
+                                }
+                            }
+                            default:
+                                break;
+                        }
                     }
-                    return false;
                 }
             }
@@ -2783 +2799 @@
 
                 /* Fetch hot-pluggable state: */
-                m_pCheckBoxHotPluggable->setVisible(slt.bus == KStorageBus_SATA);
+                m_pCheckBoxHotPluggable->setVisible((slt.bus == KStorageBus_SATA) || (slt.bus == KStorageBus_USB));
                 m_pCheckBoxHotPluggable->setChecked(fIsHotPluggable);
 
@@ -3787 +3803 @@
                     }
                 }
-                if (controllerBus == KStorageBus_SATA)
+                if ((controllerBus == KStorageBus_SATA) || (controllerBus == KStorageBus_USB))
                 {
                     if (fSuccess && isMachineOffline())
@@ -3876 +3892 @@
                     }
                 }
-                if (controllerBus == KStorageBus_SATA)
+                if ((controllerBus == KStorageBus_SATA) || (controllerBus == KStorageBus_USB))
                 {
                     if (fSuccess && isMachineOffline())
@@ -3890 +3906 @@
                 /* Show error message: */
                 msgCenter().cannotAttachDevice(m_machine, mediumTypeToLocal(attachmentDeviceType),
-                                                 vboxMedium.location(),
-                                                 StorageSlot(controllerBus, iAttachmentPort, iAttachmentDevice), this);
+                                               vboxMedium.location(),
+                                               StorageSlot(controllerBus, iAttachmentPort, iAttachmentDevice), this);
             }
         }