Changeset 55864 in vbox for trunk

Timestamp:

May 14, 2015 6:44:04 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

100320

Message:

VMMR0EntryFast: Don't return with the context hook enabled when HMR0Enter() fails.

File:

• trunk/src/VBox/VMM/VMMR0/VMMR0.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -1046 +1046 @@
                 {
                     /*
-                     * Register thread-context hooks if required.
+                     * Enable the context switching hook.
                      */
-                    if (    pVCpu->vmm.s.hCtxHook != NIL_RTTHREADCTXHOOK
-                        && !RTThreadCtxHookIsEnabled(pVCpu->vmm.s.hCtxHook))
+                    if (pVCpu->vmm.s.hCtxHook != NIL_RTTHREADCTXHOOK)
                     {
-                        rc = RTThreadCtxHookEnable(pVCpu->vmm.s.hCtxHook);
-                        AssertRC(rc);
+                        Assert(!RTThreadCtxHookIsEnabled(pVCpu->vmm.s.hCtxHook));
+                        int rc2 = RTThreadCtxHookEnable(pVCpu->vmm.s.hCtxHook); AssertRC(rc2);
                     }
 
@@ -1090 +1089 @@
                             rc = VERR_VMM_WRONG_HM_VMCPU_STATE;
                         }
+                        /** @todo Get rid of this. HM shouldn't disable the context hook. */
                         else if (RT_UNLIKELY(vmmR0ThreadCtxHookIsEnabled(pVCpu)))
                         {
                             pVM->vmm.s.szRing0AssertMsg1[0] = '\0';
                             RTStrPrintf(pVM->vmm.s.szRing0AssertMsg2, sizeof(pVM->vmm.s.szRing0AssertMsg2),
-                                        "Thread-context hooks still registered! VCPU=%p Id=%u rc=%d.\n", pVCpu, pVCpu->idCpu, rc);
+                                        "Thread-context hooks still enabled! VCPU=%p Id=%u rc=%d.\n", pVCpu, pVCpu->idCpu, rc);
                             rc = VERR_INVALID_STATE;
                         }
@@ -1102 +1102 @@
                     STAM_COUNTER_INC(&pVM->vmm.s.StatRunRC);
 
-                    /** @todo shouldn't we disable the ctx hook here??? */
+                    /*
+                     * Invalidate the host CPU identifiers before we disable the context
+                     * hook / restore preemption.
+                     */
+                    pVCpu->iHostCpuSet = UINT32_MAX;
+                    ASMAtomicWriteU32(&pVCpu->idHostCpu, NIL_RTCPUID);
+
+                    /*
+                     * Disable context hooks.  Due to unresolved cleanup issues, we
+                     * cannot leave the hooks enabled when we return to ring-3.
+                     *
+                     * Note! At the moment HM may also have disabled the hook
+                     *       when we get here, but the IPRT API handles that.
+                     */
+                    if (pVCpu->vmm.s.hCtxHook != NIL_RTTHREADCTXHOOK)
+                    {
+                        ASMAtomicWriteU32(&pVCpu->idHostCpu, NIL_RTCPUID);
+                        RTThreadCtxHookDisable(pVCpu->vmm.s.hCtxHook);
+                    }
                 }
                 /*
@@ -1108 +1126 @@
                  */
                 else
+                {
                     rc = VINF_EM_RAW_INTERRUPT;
-
-                /*
-                 * Invalidate the host CPU identifiers as we restore preemption.
-                 */
-                pVCpu->iHostCpuSet = UINT32_MAX;
-                ASMAtomicWriteU32(&pVCpu->idHostCpu, NIL_RTCPUID);
-
+                    pVCpu->iHostCpuSet = UINT32_MAX;
+                    ASMAtomicWriteU32(&pVCpu->idHostCpu, NIL_RTCPUID);
+                }
+
+                /** @todo When HM stops messing with the context hook state, we'll disable
+                 *        preemption again before the RTThreadCtxHookDisable call. */
                 if (!fPreemptRestored)
                     RTThreadPreemptRestore(&PreemptState);