Changeset 56054 in vbox for trunk/src

Timestamp:

May 24, 2015 3:52:28 PM (10 years ago)

Author:

vboxsync

Message:

PGM,CSAM: Documented that pfnInvalidateR3 does't work for the last 9 years. Build fix.

Location:

trunk/src/VBox/VMM/VMMR3

Files:

• CSAM.cpp (modified) (1 diff)
• PGMHandler.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR3/CSAM.cpp

@@ -2169 +2169 @@
  *                          calling EMT.
  * @param   GCPtr           The virtual address the guest has changed.
+ *
+ * @remarks Not currently called by PGM. It was actually only called for a month
+ *          back in 2006...
  */
 static DECLCALLBACK(int) csamR3CodePageInvalidate(PVM pVM, PVMCPU pVCpu, RTGCPTR GCPtr, void *pvUser)

trunk/src/VBox/VMM/VMMR3/PGMHandler.cpp

@@ -314 +314 @@
  *                          automatically relocated or not.
  * @param   pfnInvalidateR3 Pointer to the ring-3 invalidation handler callback.
+ *                          Warning! This callback stopped working in VBox v1.2!
  * @param   pfnHandlerR3    Pointer to the ring-3 handler callback.
  * @param   pfnHandlerRC    Pointer to the raw-mode context handler callback.
@@ -339 +340 @@
         AssertPtrNullReturn(pfnInvalidateR3, VERR_INVALID_POINTER);
         AssertPtrReturn(pfnHandlerR3, VERR_INVALID_POINTER);
-        AssertPtrReturn(pfnHandlerRC, VERR_INVALID_POINTER);
+        AssertReturn(pfnHandlerRC != NIL_RTRCPTR, VERR_INVALID_POINTER);
     }
     else
@@ -425 +426 @@
     {
         RTRCPTR pfnPfHandlerRC = NIL_RTRCPTR;
-        int rc = PDMR3LdrGetSymbolRCLazy(pVM, VMMRC_MAIN_MODULE_NAME, NULL /*pszSearchPath*/, pszPfHandlerRC, &pfnPfHandlerRC);
+        rc = PDMR3LdrGetSymbolRCLazy(pVM, VMMRC_MAIN_MODULE_NAME, NULL /*pszSearchPath*/, pszPfHandlerRC, &pfnPfHandlerRC);
         if (RT_SUCCESS(rc))
             return PGMR3HandlerVirtualTypeRegisterEx(pVM, enmKind, fRelocUserRC,