Changeset 56656 in vbox

Timestamp:

Jun 26, 2015 8:51:18 AM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

101292

Message:

DnD/Main: GuestDnDTargetImpl.cpp: Some more error checking, return values.

File:

• trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp (modified) (13 diffs)

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -241 +241 @@
 
 HRESULT GuestDnDTarget::enter(ULONG aScreenId, ULONG aX, ULONG aY,
-                              DnDAction_T aDefaultAction,
-                              const std::vector<DnDAction_T> &aAllowedActions,
+                              DnDAction_T                      aDefaultAction,
+                              const std::vector<DnDAction_T>  &aAllowedActions,
                               const std::vector<com::Utf8Str> &aFormats,
-                              DnDAction_T *aResultAction)
+                              DnDAction_T                     *aResultAction)
 {
 #if !defined(VBOX_WITH_DRAG_AND_DROP)
@@ -281 +281 @@
     /* If there is no valid supported format, ignore this request. */
     if (strFormats.isEmpty())
-        return S_OK;
+        return setError(E_INVALIDARG, tr("Specified format(s) not supported"));
+
+    LogRel2(("DnD: Offered formats to guest:\n"));
+    RTCList<RTCString> lstFormats = strFormats.split("\r\n");
+    for (size_t i = 0; i < lstFormats.size(); i++)
+        LogRel2(("DnD: \t%s\n", lstFormats[i].c_str()));
+
+    /* Save the formats offered to the guest. This is needed to later
+     * decide what to do with the data when sending stuff to the guest. */
+    m_vecFmtOff = aFormats;
+    Assert(m_vecFmtOff.size());
 
     HRESULT hr = S_OK;
@@ -308 +318 @@
     }
 
-    if (aResultAction)
-        *aResultAction = resAction;
+    if (RT_FAILURE(rc))
+        hr = VBOX_E_IPRT_ERROR;
+
+    if (SUCCEEDED(hr))
+    {
+        if (aResultAction)
+            *aResultAction = resAction;
+    }
 
     LogFlowFunc(("hr=%Rhrc, resAction=%ld\n", hr, resAction));
@@ -317 +333 @@
 
 HRESULT GuestDnDTarget::move(ULONG aScreenId, ULONG aX, ULONG aY,
-                             DnDAction_T aDefaultAction,
-                             const std::vector<DnDAction_T> &aAllowedActions,
+                             DnDAction_T                      aDefaultAction,
+                             const std::vector<DnDAction_T>  &aAllowedActions,
                              const std::vector<com::Utf8Str> &aFormats,
-                             DnDAction_T *aResultAction)
+                             DnDAction_T                     *aResultAction)
 {
 #if !defined(VBOX_WITH_DRAG_AND_DROP)
@@ -347 +363 @@
     /* If there is no valid supported format, ignore this request. */
     if (strFormats.isEmpty())
-        return S_OK;
+        return setError(E_INVALIDARG, tr("Specified format(s) not supported"));
 
     HRESULT hr = S_OK;
@@ -373 +389 @@
     }
 
-    if (aResultAction)
-        *aResultAction = resAction;
+    if (RT_FAILURE(rc))
+        hr = VBOX_E_IPRT_ERROR;
+
+    if (SUCCEEDED(hr))
+    {
+        if (aResultAction)
+            *aResultAction = resAction;
+    }
 
     LogFlowFunc(("hr=%Rhrc, *pResultAction=%ld\n", hr, resAction));
@@ -400 +422 @@
     }
 
+    if (RT_FAILURE(rc))
+        hr = VBOX_E_IPRT_ERROR;
+
     LogFlowFunc(("hr=%Rhrc\n", hr));
     return hr;
@@ -406 +431 @@
 
 HRESULT GuestDnDTarget::drop(ULONG aScreenId, ULONG aX, ULONG aY,
-                             DnDAction_T aDefaultAction,
-                             const std::vector<DnDAction_T> &aAllowedActions,
+                             DnDAction_T                      aDefaultAction,
+                             const std::vector<DnDAction_T>  &aAllowedActions,
                              const std::vector<com::Utf8Str> &aFormats,
-                             com::Utf8Str &aFormat, DnDAction_T *aResultAction)
+                             com::Utf8Str                    &aFormat,
+                             DnDAction_T                     *aResultAction)
 {
 #if !defined(VBOX_WITH_DRAG_AND_DROP)
@@ -432 +458 @@
     /* If there is no usable action, ignore this request. */
     if (isDnDIgnoreAction(uDefAction))
+    {
+        aFormat = "";
+        if (aResultAction)
+            *aResultAction = DnDAction_Ignore;
         return S_OK;
+    }
 
     /* Make a flat data string out of the supported format list. */
@@ -438 +469 @@
     /* If there is no valid supported format, ignore this request. */
     if (strFormats.isEmpty())
-        return S_OK;
+        return setError(E_INVALIDARG, tr("Specified format(s) not supported"));
 
     HRESULT hr = S_OK;
@@ -471 +502 @@
     }
 
-    if (aResultAction)
-        *aResultAction = resAction;
-
+    if (RT_FAILURE(rc))
+        hr = VBOX_E_IPRT_ERROR;
+
+    if (SUCCEEDED(hr))
+    {
+        if (aResultAction)
+            *aResultAction = resAction;
+    }
+
+    LogFlowFunc(("Returning hr=%Rhrc\n", hr));
     return hr;
 #endif /* VBOX_WITH_DRAG_AND_DROP */
@@ -681 +719 @@
 {
     AssertPtrReturn(pCtx, VERR_INVALID_POINTER);
-
-    GuestDnD *pInst = GuestDnDInst();
-    if (!pInst)
-        return VERR_INVALID_POINTER;
 
     int rc;
@@ -1301 +1335 @@
         *aVeto = FALSE; /** @todo */
 
-    return RT_SUCCESS(rc) ? S_OK : VBOX_E_IPRT_ERROR;
+    HRESULT hr = RT_SUCCESS(rc) ? S_OK : VBOX_E_IPRT_ERROR;
+
+    LogFlowFunc(("hr=%Rhrc\n", hr));
+    return hr;
 #endif /* VBOX_WITH_DRAG_AND_DROP */
 }