Changeset 56662 in vbox

Timestamp:

Jun 26, 2015 4:31:12 PM (9 years ago)

Author:

vboxsync

Message:

Main: When changing audio controller, change codec as well.

File:

• trunk/src/VBox/Main/src-server/AudioAdapterImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-server/AudioAdapterImpl.cpp

@@ -323 +323 @@
     if (mData->m->mAudioController != aAudioController)
     {
+        AudioCodecType_T defaultCodec;
+
         /*
          * which audio hardware type are we supposed to use?
@@ -328 +330 @@
         switch (aAudioController)
         {
+            /* codec type needs to match the controller. */
             case AudioControllerType_AC97:
+                defaultCodec = AudioCodecType_STAC9700;
+                break;
             case AudioControllerType_SB16:
+                defaultCodec = AudioCodecType_SB16;
+                break;
             case AudioControllerType_HDA:
-            {
-                mData->m.backup();
-                mData->m->mAudioController = aAudioController;
-                alock.release();
-                AutoWriteLock mlock(mParent COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
-                mParent->i_setModified(Machine::IsModified_AudioAdapter);
+                defaultCodec = AudioCodecType_STAC9221;
                 break;
-            }
 
             default:
@@ -345 +346 @@
                 rc = E_FAIL;
         }
+        if (rc == S_OK)
+        {
+            mData->m.backup();
+            mData->m->mAudioController = aAudioController;
+            mData->m->mAudioCodec = defaultCodec;
+            alock.release();
+            AutoWriteLock mlock(mParent COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
+            mParent->i_setModified(Machine::IsModified_AudioAdapter);
+        }
     }
 
@@ -370 +380 @@
 
     /*
-     * which audio hardware type are we supposed to use?
+     * ensure that the codec type matches the audio controller
      */
     switch (mData->m->mAudioController)