Changeset 56666 in vbox for trunk/src/VBox

Timestamp:

Jun 28, 2015 4:25:06 PM (9 years ago)

Author:

vboxsync

Message:

hmR0SvmExitIOInstr: Optimize the OUTS on old-CPU when it's clear from the instruction size that no segment prefixes are used. Build fix for signed/unsigned comparison.

File:

• trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -4804 +4804 @@
             if (cbInstr <= 15 && cbInstr >= 1)
             {
-                Assert(cbInstr >= 1 + IoExitInfo.n.u1REP);
+                Assert(cbInstr >= 1U + IoExitInfo.n.u1REP);
                 if (IoExitInfo.n.u1Type == SVM_IOIO_WRITE)
                 {
@@ -4813 +4813 @@
                         && pVM->cpum.ro.GuestFeatures.enmMicroarch >= kCpumMicroarch_AMD_15h_First)
                     {
-                        AssertMsg(IoExitInfo.n.u3SEG == X86_SREG_DS || cbInstr > 1 + IoExitInfo.n.u1REP,
+                        AssertMsg(IoExitInfo.n.u3SEG == X86_SREG_DS || cbInstr > 1U + IoExitInfo.n.u1REP,
                                   ("u32Seg=%d cbInstr=%d u1REP=%d", IoExitInfo.n.u3SEG, cbInstr, IoExitInfo.n.u1REP));
                         rcStrict = IEMExecStringIoWrite(pVCpu, cbValue, enmAddrMode, IoExitInfo.n.u1REP, (uint8_t)cbInstr,
                                                         IoExitInfo.n.u3SEG);
                     }
+                    else if (cbInstr != 1U + IoExitInfo.n.u1REP)
+                        rcStrict = IEMExecStringIoWrite(pVCpu, cbValue, enmAddrMode, IoExitInfo.n.u1REP, (uint8_t)cbInstr,
+                                                        X86_SREG_DS);
                     else
                         rcStrict = IEMExecOne(pVCpu);