Changeset 56827 in vbox for trunk

Timestamp:

Jul 7, 2015 7:53:31 AM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

101479

Message:

HostServices/SharedOpenGL: Missing return in the out of memroy error path which would lead to NULL pointer dereferences later on

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_getshaders.c (modified) (13 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_getshaders.c

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2009-2012 Oracle Corporation
+ * Copyright (C) 2009-2015 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -46 +46 @@
         zero.length = 0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* zero out just the header to ensure it initially contains zero size values */
@@ -64 +65 @@
         zero.length = 0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* zero out just the header to ensure it initially contains zero size values */
@@ -81 +83 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -107 +110 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -136 +140 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -157 +162 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -174 +180 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -192 +199 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     /* initial (fallback )value */
@@ -214 +222 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
     
@@ -237 +246 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
 
@@ -268 +278 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }
 
@@ -286 +297 @@
         GLsizei zero=0;
         crServerReturnValue(&zero, sizeof(zero));
+        return;
     }