Changeset 56986 in vbox

Timestamp:

Jul 18, 2015 10:12:53 PM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

101698

Message:

Debugger: Logging and assertion formatting fixes.

Location:

trunk/src/VBox/Debugger

Files:

• DBGCEval.cpp (modified) (3 diffs)
• DBGPlugInDarwin.cpp (modified) (1 diff)
• DBGPlugInWinNt.cpp (modified) (2 diffs)

trunk/src/VBox/Debugger/DBGCEval.cpp

@@ -871 +871 @@
 
                 default:
-                    AssertMsgFailedReturn(("Invalid type %d\n"), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
+                    AssertMsgFailedReturn(("Invalid type %d\n", pArg->enmType), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
             }
             break;                      /* (not reached) */
@@ -925 +925 @@
 
                 default:
-                    AssertMsgFailedReturn(("Invalid type %d\n"), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
+                    AssertMsgFailedReturn(("Invalid type %d\n", pArg->enmType), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
             }
             break;                      /* (not reached) */
@@ -972 +972 @@
 
                 default:
-                    AssertMsgFailedReturn(("Invalid type %d\n"), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
+                    AssertMsgFailedReturn(("Invalid type %d\n", pArg->enmType), VERR_DBGC_PARSE_INCORRECT_ARG_TYPE);
             }
             break;                      /* (not reached) */

trunk/src/VBox/Debugger/DBGPlugInDarwin.cpp

@@ -296 +296 @@
     }
     else
-        Log(("dbgDiggerDarwinIDmsg_QueryKernelLog: Error reading %#x bytes at %RGv: %Rrc\n", MsgBuf.msg_size, MsgBuf.msg_bufc));
+        Log(("dbgDiggerDarwinIDmsg_QueryKernelLog: Error reading %#x bytes at %RGv: %Rrc\n", MsgBuf.msg_size, MsgBuf.msg_bufc, rc));
     RTMemFree(pchMsgBuf);
     return rc;

trunk/src/VBox/Debugger/DBGPlugInWinNt.cpp

@@ -622 +622 @@
              || pMzHdr->e_lfanew + sizeof(IMAGE_NT_HEADERS64) > cbImage)
     {
-        Log(("DigWinNt: %s: PE header to far into image: %#x  cbImage=%#x\n", pMzHdr->e_lfanew, cbImage));
+        Log(("DigWinNt: %s: PE header to far into image: %#x  cbImage=%#x\n", pszName, pMzHdr->e_lfanew, cbImage));
         return;
     }
@@ -633 +633 @@
     else
     {
-        Log(("DigWinNt: %s: PE header to far into image (lazy bird): %#x\n",  pMzHdr->e_lfanew));
+        Log(("DigWinNt: %s: PE header to far into image (lazy bird): %#x\n", pszName, pMzHdr->e_lfanew));
         return;
     }