Changeset 57332 in vbox

Timestamp:

Aug 13, 2015 3:21:13 PM (9 years ago)

Author:

vboxsync

Message:

Main/Machine: fix list of allowed machine states when guest properties are updated, as previously it was too strict and lead to (for devs) annoying assertions.

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -13388 +13388 @@
         AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-        switch (mData->mMachineState)
-        {
-            case MachineState_Paused:
-            case MachineState_Running:
-            case MachineState_Teleporting:
-            case MachineState_TeleportingPausedVM:
-            case MachineState_OnlineSnapshotting:
-            case MachineState_LiveSnapshotting:
-            case MachineState_DeletingSnapshotOnline:
-            case MachineState_DeletingSnapshotPaused:
-            case MachineState_Saving:
-            case MachineState_Stopping:
-                break;
-
-            default:
-                AssertMsgFailedReturn(("%s\n", Global::stringifyMachineState(mData->mMachineState)),
-                                      VBOX_E_INVALID_VM_STATE);
+        if (!Global::IsOnline(mData->mMachineState))
+        {
+            AssertMsgFailedReturn(("%s\n", Global::stringifyMachineState(mData->mMachineState)),
+                                  VBOX_E_INVALID_VM_STATE);
         }