VirtualBox

Changeset 57482 in vbox for trunk/src/VBox/VMM


Ignore:
Timestamp:
Aug 20, 2015 4:48:33 PM (9 years ago)
Author:
vboxsync
Message:

VMM: doxygen and nits.

Location:
trunk/src/VBox/VMM
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/VMM/VMMAll/HMAll.cpp

    r57470 r57482  
    5959 * @returns VBox status code.
    6060 * @param   pVCpu       Pointer to the VMCPU.
    61  * @param   GCVirt      Page to invalidate
     61 * @param   GCVirt      Page to invalidate.
    6262 */
    6363static void hmQueueInvlPage(PVMCPU pVCpu, RTGCPTR GCVirt)
    … …  
    7676 * @returns VBox status code.
    7777 * @param   pVCpu       Pointer to the VMCPU.
    78  * @param   GCVirt      Page to invalidate
     78 * @param   GCVirt      Page to invalidate.
    7979 */
    8080VMM_INT_DECL(int) HMInvalidatePage(PVMCPU pVCpu, RTGCPTR GCVirt)
    … …  
    122122    return;
    123123}
     124
    124125
    125126/**
    … …  
    357358}
    358359
    359 /**
    360  * Invalidates a guest page by physical address
    361  *
    362  * NOTE: Assumes the current instruction references this physical page though a virtual address!!
     360
     361/**
     362 * Invalidates a guest page by physical address.
    363363 *
    364364 * @returns VBox status code.
    365365 * @param   pVM         Pointer to the VM.
    366  * @param   GCPhys      Page to invalidate
     366 * @param   GCPhys      Page to invalidate.
     367 *
     368 * @remarks Assumes the current instruction references this physical page
     369 *          though a virtual address!
    367370 */
    368371VMM_INT_DECL(int) HMInvalidatePhysPage(PVM pVM, RTGCPHYS GCPhys)

  • trunk/src/VBox/VMM/VMMR3/HM.cpp

    r57479 r57482  
    311311static DECLCALLBACK(int) hmR3Save(PVM pVM, PSSMHANDLE pSSM);
    312312static DECLCALLBACK(int) hmR3Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass);
    313 static int hmR3InitCPU(PVM pVM);
    314 static int hmR3InitFinalizeR0(PVM pVM);
    315 static int hmR3InitFinalizeR0Intel(PVM pVM);
    316 static int hmR3InitFinalizeR0Amd(PVM pVM);
    317 static int hmR3TermCPU(PVM pVM);
     313static int               hmR3InitCPU(PVM pVM);
     314static int               hmR3InitFinalizeR0(PVM pVM);
     315static int               hmR3InitFinalizeR0Intel(PVM pVM);
     316static int               hmR3InitFinalizeR0Amd(PVM pVM);
     317static int               hmR3TermCPU(PVM pVM);
    318318
    319319
    … …  
    453453     * The pause-filter exiting window in TSC ticks. When the number of ticks
    454454     * between the current PAUSE instruction and first PAUSE of a loop exceeds
    455      * VmxPleWindow, a VM-exit is trigerred.
     455     * VmxPleWindow, a VM-exit is triggered.
    456456     *
    457457     * Setting VmxPleGap and VmxPleGap to 0 disables pause-filter exiting.
    … …  
    10641064
    10651065    /*
    1066      * Do the vendor specific initalization                                                                                                               .
     1066     * Do the vendor specific initialization                                                                                                               .
    10671067     *                                                                                                                                                    .
    10681068     * Note! We disable release log buffering here since we're doing relatively                                                                           .
    … …  
    16481648        pVCpu->hm.s.vmx.fWasInRealMode = true;
    16491649    }
    1650 
    1651     /** @todo r=ramshankar: Disabling for now. If nothing breaks remove it
    1652      *        eventually. (Test platforms that use the cache ofc). */
    1653 #if 0
    1654 #ifdef VMX_USE_CACHED_VMCS_ACCESSES
    1655     /* Reset the contents of the read cache. */
    1656     PVMCSCACHE pCache = &pVCpu->hm.s.vmx.VMCSCache;
    1657     for (unsigned j = 0; j < pCache->Read.cValidEntries; j++)
    1658         pCache->Read.aFieldVal[j] = 0;
    1659 #endif
    1660 #endif
    16611650}
    16621651
    … …  
    24662455     * we also treat segments with all the attributes cleared as unusable.
    24672456     */
    2468     /** @todo r=bird: actually all zeros isn't gonna cut it... SS.DPL == CPL. */
     2457    /** @todo r=bird: actually all zeroes isn't gonna cut it... SS.DPL == CPL. */
    24692458    if (pSel->Attr.n.u1Unusable || !pSel->Attr.u)
    24702459        return true;
    … …  
    29332922            uint32_t u32Val  = 0;
    29342923
    2935             rcStrict = IOMIOPortRead(pVM, pVCpu, pVCpu->hm.s.PendingIO.s.Port.uPort,
    2936                                      &u32Val,
     2924            rcStrict = IOMIOPortRead(pVM, pVCpu, pVCpu->hm.s.PendingIO.s.Port.uPort, &u32Val,
    29372925                                     pVCpu->hm.s.PendingIO.s.Port.cbSize);
    29382926            if (IOM_SUCCESS(rcStrict))

  • trunk/src/VBox/VMM/VMMR3/VMM.cpp

    r57470 r57482  
    120120#include <iprt/ctype.h>
    121121#include <iprt/x86.h>
    122 
    123122
    124123
    … …  
    735734 * Terminate the VMM bits.
    736735 *
    737  * @returns VINF_SUCCESS.
     736 * @returns VBox status code.
    738737 * @param   pVM         Pointer to the VM.
    739738 */
    … …  
    11341133 * @returns VBox status
    11351134 * @param   pVM             Pointer to the VM.
    1136  * @param   pszSymbol       Symbol to resolv
     1135 * @param   pszSymbol       Symbol to resolve.
    11371136 * @param   pRCPtrValue     Where to store the symbol value.
    11381137 *
    … …  
    13841383}
    13851384
     1385
    13861386/**
    13871387 * VCPU worker for VMMSendSipi.
    13881388 *
    13891389 * @param   pVM         Pointer to the VM.
    1390  * @param   idCpu       Virtual CPU to perform SIPI on
    1391  * @param   uVector     SIPI vector
     1390 * @param   idCpu       Virtual CPU to perform SIPI on.
     1391 * @param   uVector     SIPI vector.
    13921392 */
    13931393static DECLCALLBACK(int) vmmR3SendSipi(PVM pVM, VMCPUID idCpu, uint32_t uVector)
    … …  
    14221422}
    14231423
     1424
    14241425static DECLCALLBACK(int) vmmR3SendInitIpi(PVM pVM, VMCPUID idCpu)
    14251426{
    … …  
    14401441}
    14411442
     1443
    14421444/**
    14431445 * Sends SIPI to the virtual CPU by setting CS:EIP into vector-dependent state
    1444  * and unhalting processor
     1446 * and unhalting processor.
    14451447 *
    14461448 * @param   pVM         Pointer to the VM.
    1447  * @param   idCpu       Virtual CPU to perform SIPI on
    1448  * @param   uVector     SIPI vector
     1449 * @param   idCpu       Virtual CPU to perform SIPI on.
     1450 * @param   uVector     SIPI vector.
    14491451 */
    14501452VMMR3_INT_DECL(void) VMMR3SendSipi(PVM pVM, VMCPUID idCpu,  uint32_t uVector)
    … …  
    14561458}
    14571459
     1460
    14581461/**
    14591462 * Sends init IPI to the virtual CPU.
    14601463 *
    14611464 * @param   pVM         Pointer to the VM.
    1462  * @param   idCpu       Virtual CPU to perform int IPI on
     1465 * @param   idCpu       Virtual CPU to perform int IPI on.
    14631466 */
    14641467VMMR3_INT_DECL(void) VMMR3SendInitIpi(PVM pVM, VMCPUID idCpu)
    … …  
    14701473}
    14711474
    1472 /**
    1473  * Registers the guest memory range that can be used for patching
     1475
     1476/**
     1477 * Registers the guest memory range that can be used for patching.
    14741478 *
    14751479 * @returns VBox status code.
    14761480 * @param   pVM         Pointer to the VM.
    1477  * @param   pPatchMem   Patch memory range
    1478  * @param   cbPatchMem  Size of the memory range
     1481 * @param   pPatchMem   Patch memory range.
     1482 * @param   cbPatchMem  Size of the memory range.
    14791483 */
    14801484VMMR3DECL(int) VMMR3RegisterPatchMemory(PVM pVM, RTGCPTR pPatchMem, unsigned cbPatchMem)
    … …  
    14871491}
    14881492
    1489 /**
    1490  * Deregisters the guest memory range that can be used for patching
     1493
     1494/**
     1495 * Deregisters the guest memory range that can be used for patching.
    14911496 *
    14921497 * @returns VBox status code.
    14931498 * @param   pVM         Pointer to the VM.
    1494  * @param   pPatchMem   Patch memory range
    1495  * @param   cbPatchMem  Size of the memory range
     1499 * @param   pPatchMem   Patch memory range.
     1500 * @param   cbPatchMem  Size of the memory range.
    14961501 */
    14971502VMMR3DECL(int) VMMR3DeregisterPatchMemory(PVM pVM, RTGCPTR pPatchMem, unsigned cbPatchMem)
    … …  
    21382143 * @param   pVM     Pointer to the VM.
    21392144 * @param   pVCpu   Pointer to the VMCPU.
    2140  * @remark  Careful with critsects.
     2145 * @remarks Careful with critsects.
    21412146 */
    21422147static int vmmR3ServiceCallRing3Request(PVM pVM, PVMCPU pVCpu)
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette