Changeset 57678 in vbox for trunk

Timestamp:

Sep 9, 2015 7:20:36 PM (9 years ago)

Author:

vboxsync

Message:

testresults.py: the 'unit' attribute can be empty (RTTESTUNIT_NONE).

File:

• trunk/src/VBox/ValidationKit/testmanager/core/testresults.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/testresults.py

@@ -519 +519 @@
     ksResultsGroupingTypeTestCase   = 'ResultsGroupingTypeTestCase';
     ksResultsGroupingTypeSchedGroup = 'ResultsGroupingTypeSchedGroup';
-
-    #kdResultGroupingMapOld = {
-    #    ksResultsGroupingTypeNone:       ('TestSets',            None,                      None),
-    #    ksResultsGroupingTypeTestGroup:  ('TestSets',            'TestSets.idTestGroup',    None),
-    #    ksResultsGroupingTypeTestBox:    ('TestSets',            'TestSets.idTestBox',      None),
-    #    ksResultsGroupingTypeTestCase:   ('TestSets',            'TestSets.idTestCase',     None),
-    #    ksResultsGroupingTypeBuildRev:   ('TestSets, Builds',    'Builds.iRevision',
-    #                                      ' AND Builds.idBuild      = TestSets.idBuild'
-    #                                      ' AND Builds.tsExpire     > TestSets.tsCreated'
-    #                                      ' AND Builds.tsEffective <= TestSets.tsCreated' ),
-    #    ksResultsGroupingTypeSchedGroup: ('TestSets, TestBoxes', 'TestBoxes.idSchedGroup',
-    #                                      ' AND TestSets.idGenTestBox = TestBoxes.idGenTestBox'),
-    #};
 
     ## @name Result sorting options.
@@ -1492 +1479 @@
         # Validate string attributes.
         for sAttr in [ 'name', 'unit', 'text' ]:
-            if sAttr in dAttribs and len(dAttribs[sAttr]) == 0:
+            if sAttr in dAttribs and (len(dAttribs[sAttr]) == 0 or sAttr == 'unit'):
                 return 'Element %s has an empty %s attribute value.' % (sName, sAttr,);