VirtualBox

Changeset 57683 in vbox for trunk/src/VBox/VMM/VMMR3


Ignore:
Timestamp:
Sep 10, 2015 10:06:33 AM (9 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
102586
Message:

VMM/PDM: clear driver instance data after destruction, to catch use after free (the audio code used to be buggy, which is fixed for a while now)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • TabularUnified trunk/src/VBox/VMM/VMMR3/PDM.cpp

    r57358 r57683  
    611611            pDrvIns->Internal.s.pDrv->cInstances--;
    612612
     613            /* Order of resource freeing like in pdmR3DrvDestroyChain, but
     614             * not all need to be done as they are done globally later. */
     615            //PDMR3QueueDestroyDriver(pVM, pDrvIns);
    613616            TMR3TimerDestroyDriver(pVM, pDrvIns);
    614             //PDMR3QueueDestroyDriver(pVM, pDrvIns);
     617            SSMR3DeregisterDriver(pVM, pDrvIns, NULL, 0);
    615618            //pdmR3ThreadDestroyDriver(pVM, pDrvIns);
    616             SSMR3DeregisterDriver(pVM, pDrvIns, NULL, 0);
     619            //DBGFR3InfoDeregisterDriver(pVM, pDrvIns, NULL);
     620            //pdmR3CritSectBothDeleteDriver(pVM, pDrvIns);
     621            //PDMR3BlkCacheReleaseDriver(pVM, pDrvIns);
     622#ifdef VBOX_WITH_PDM_ASYNC_COMPLETION
     623            //pdmR3AsyncCompletionTemplateDestroyDriver(pVM, pDrvIns);
     624#endif
     625
     626            /* Clear the driver struture to catch sloppy code. */
     627            ASMMemFill32(pDrvIns, RT_OFFSETOF(PDMDRVINS, achInstanceData[pDrvIns->pReg->cbInstance]), 0xdeadd0d0);
    617628
    618629            pDrvIns = pDrvNext;
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette